Re: [PATCH v2] scsi: NCR5380: Mark expected switch fall-through

2019-03-06 Thread Martin K. Petersen
Hi Finn, Please submit this as a formal patch. Thanks! > Here's an alternative patch, which has the virtue that a simple heuristic > will work. This patch does not require that other static analysis tools > will follow gcc's weird rules about hyphens. (I assume they don't but I > didn't chec

Re: [PATCH v2] scsi: NCR5380: Mark expected switch fall-through

2019-02-28 Thread Michael Schmitz
Finn's version looks fine to me. Cheers,     Michael On 1/03/19 2:16 PM, Finn Thain wrote: On Thu, 28 Feb 2019, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This switch case is already marked. So I t

Re: [PATCH v2] scsi: NCR5380: Mark expected switch fall-through

2019-02-28 Thread Finn Thain
On Thu, 28 Feb 2019, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > This switch case is already marked. So I think the patch description should state that this patch is actually a workaround for a gcc

[PATCH v2] scsi: NCR5380: Mark expected switch fall-through

2019-02-28 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: In file included from drivers/scsi/dmx3191d.c:48: drivers/scsi/NCR5380.c: In function ‘NCR5380_information_transfer’: drivers/scsi/NCR5380.c:1933:9: