Re: [PATCH v2] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-10 Thread Gon Solo
> > This is not necessary as it was Python's fault and is fixed by 3.13.3 > > which came out yesterday. I just checked. > > It will take some time before this reaches all distributions. This > patch is relatively simple. > > I might be biased, but I think the benefits outweigh the cons. 3.13.3 i

Re: [PATCH v2] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-10 Thread Greg Kroah-Hartman
On Thu, Apr 10, 2025 at 08:21:09AM +0200, Gon Solo wrote: > > > This is not necessary as it was Python's fault and is fixed by 3.13.3 > > > which came out yesterday. I just checked. > > > > It will take some time before this reaches all distributions. This > > patch is relatively simple. > > > >

Re: [PATCH v2] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-09 Thread Ricardo Ribalda
On Wed, 9 Apr 2025 at 22:40, Gon Solo wrote: > > Am Wed, Apr 09, 2025 at 08:04:19PM + schrieb Ricardo Ribalda: > > Changes in v2: > > - Make repo a local variable > > - Link to v1: > > https://lore.kernel.org/r/20250225-spx-v1-1-e935b27eb...@chromium.org > > This is not necessary as it was Py

Re: [PATCH v2] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-09 Thread Gon Solo
Am Wed, Apr 09, 2025 at 08:04:19PM + schrieb Ricardo Ribalda: > Changes in v2: > - Make repo a local variable > - Link to v1: > https://lore.kernel.org/r/20250225-spx-v1-1-e935b27eb...@chromium.org This is not necessary as it was Python's fault and is fixed by 3.13.3 which came out yesterday.

[PATCH v2] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-09 Thread Ricardo Ribalda
If the git.Repo object's scope extends to the Python interpreter's shutdown phase, its destructor may fail due to the interpreter's state. Exception ignored in: Traceback (most recent call last): File "/usr/lib/python3/dist-packages/git/cmd.py", line 565, in __del__ File "/usr/lib/python3/dis