Re: [PATCH v2] scripts/setlocalversion: make git describe output more reliable

2020-09-24 Thread Masahiro Yamada
On Thu, Sep 17, 2020 at 3:56 PM Rasmus Villemoes wrote: > > When building for an embedded target using Yocto, we're sometimes > observing that the version string that gets built into vmlinux (and > thus what uname -a reports) differs from the path under /lib/modules/ > where modules get installed

Re: [PATCH v2] scripts/setlocalversion: make git describe output more reliable

2020-09-21 Thread Nico Schottelius
Hey Rasmus, Rasmus Villemoes writes: >> So I suggest you introduce something on the line of: >> >> ... >> num_chars=12 >> ... >> --abbrev=$num_chars > > I considered that, but it becomes quite ugly since it needs to get into > the awk script (as a 13, though perhaps we could get awk to do the +

Re: [PATCH v2] scripts/setlocalversion: make git describe output more reliable

2020-09-17 Thread Rasmus Villemoes
On 17/09/2020 14.22, Nico Schottelius wrote: > > Thanks for the patch Rasmus. Overall it looks good to me, be aligned to > the stable patch submission rules makes sense. A tiny thing though: > > I did not calculate the exact collision probability with 12 characters For reference, the math is som

Re: [PATCH v2] scripts/setlocalversion: make git describe output more reliable

2020-09-17 Thread Nico Schottelius
Thanks for the patch Rasmus. Overall it looks good to me, be aligned to the stable patch submission rules makes sense. A tiny thing though: I did not calculate the exact collision probability with 12 characters and it does not make sense to even discuss this, if this is a current rule for stable

[PATCH v2] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Rasmus Villemoes
When building for an embedded target using Yocto, we're sometimes observing that the version string that gets built into vmlinux (and thus what uname -a reports) differs from the path under /lib/modules/ where modules get installed in the rootfs, but only in the length of the -gabc123def suffix. He