Re: [PATCH v2] sched/fair: check for idle core

2021-02-06 Thread Julia Lawall
On Mon, 25 Jan 2021, Vincent Guittot wrote: > On Mon, 25 Jan 2021 at 10:20, Julia Lawall wrote: > > > > > > > > On Mon, 25 Jan 2021, Mel Gorman wrote: > > > > > On Sun, Jan 24, 2021 at 09:38:14PM +0100, Julia Lawall wrote: > > > > > > > > > > > > On Tue, 27 Oct 2020, Mel Gorman wrote: > > > >

Re: [PATCH v2] sched/fair: check for idle core

2021-01-26 Thread Mel Gorman
On Sun, Jan 24, 2021 at 09:38:14PM +0100, Julia Lawall wrote: > > > On Tue, 27 Oct 2020, Mel Gorman wrote: > > > On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote: > > > Fixes: 11f10e5420f6 ("sched/fair: Use load instead of runnable load in > > > wakeup path") > > > Signed-off-by: Ju

Re: [PATCH v2] sched/fair: check for idle core

2021-01-25 Thread Julia Lawall
On Mon, 25 Jan 2021, Vincent Guittot wrote: > On Mon, 25 Jan 2021 at 10:20, Julia Lawall wrote: > > > > > > > > On Mon, 25 Jan 2021, Mel Gorman wrote: > > > > > On Sun, Jan 24, 2021 at 09:38:14PM +0100, Julia Lawall wrote: > > > > > > > > > > > > On Tue, 27 Oct 2020, Mel Gorman wrote: > > > >

Re: [PATCH v2] sched/fair: check for idle core

2021-01-25 Thread Julia Lawall
On Mon, 25 Jan 2021, Mel Gorman wrote: > On Sun, Jan 24, 2021 at 09:38:14PM +0100, Julia Lawall wrote: > > > > > > On Tue, 27 Oct 2020, Mel Gorman wrote: > > > > > On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote: > > > > Fixes: 11f10e5420f6 ("sched/fair: Use load instead of runnabl

Re: [PATCH v2] sched/fair: check for idle core

2021-01-25 Thread Vincent Guittot
On Mon, 25 Jan 2021 at 10:20, Julia Lawall wrote: > > > > On Mon, 25 Jan 2021, Mel Gorman wrote: > > > On Sun, Jan 24, 2021 at 09:38:14PM +0100, Julia Lawall wrote: > > > > > > > > > On Tue, 27 Oct 2020, Mel Gorman wrote: > > > > > > > On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote:

Re: [PATCH v2] sched/fair: check for idle core

2021-01-24 Thread Julia Lawall
On Tue, 27 Oct 2020, Mel Gorman wrote: > On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote: > > Fixes: 11f10e5420f6 ("sched/fair: Use load instead of runnable load in > > wakeup path") > > Signed-off-by: Julia Lawall > > Reviewed-by Vincent Guittot > > > > While not a universal wi

Re: [PATCH v2] sched/fair: check for idle core

2020-10-27 Thread Julia Lawall
On Tue, 27 Oct 2020, Mel Gorman wrote: > On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote: > > Fixes: 11f10e5420f6 ("sched/fair: Use load instead of runnable load in > > wakeup path") > > Signed-off-by: Julia Lawall > > Reviewed-by Vincent Guittot > > > > While not a universal wi

Re: [PATCH v2] sched/fair: check for idle core

2020-10-27 Thread Mel Gorman
On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote: > Fixes: 11f10e5420f6 ("sched/fair: Use load instead of runnable load in wakeup > path") > Signed-off-by: Julia Lawall > Reviewed-by Vincent Guittot > While not a universal win, it was mostly a win or neutral. In few cases where the

Re: [PATCH v2] sched/fair: check for idle core

2020-10-23 Thread Julia Lawall
On Sat, 24 Oct 2020, Chen Yu wrote: > On Fri, Oct 23, 2020 at 1:32 AM Julia Lawall wrote: > > > [cut] > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index aa4c6227cd6d..9b23dad883ee 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -5804,6 +5804,9 @@ wak

Re: [PATCH v2] sched/fair: check for idle core

2020-10-23 Thread Chen Yu
On Fri, Oct 23, 2020 at 1:32 AM Julia Lawall wrote: > [cut] > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index aa4c6227cd6d..9b23dad883ee 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -5804,6 +5804,9 @@ wake_affine_idle(int this_cpu, int prev_cpu, int sync) >

Re: [PATCH v2] sched/fair: check for idle core

2020-10-23 Thread Mel Gorman
On Fri, Oct 23, 2020 at 11:21:50AM +0200, Julia Lawall wrote: > > > On Fri, 23 Oct 2020, Mel Gorman wrote: > > > On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote: > > > In the case of a thread wakeup, wake_affine determines whether a core > > > will be chosen for the thread on the so

Re: [PATCH v2] sched/fair: check for idle core

2020-10-23 Thread Julia Lawall
On Fri, 23 Oct 2020, Mel Gorman wrote: > On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote: > > In the case of a thread wakeup, wake_affine determines whether a core > > will be chosen for the thread on the socket where the thread ran > > previously or on the socket of the waker. Th

Re: [PATCH v2] sched/fair: check for idle core

2020-10-23 Thread Mel Gorman
On Thu, Oct 22, 2020 at 03:15:50PM +0200, Julia Lawall wrote: > In the case of a thread wakeup, wake_affine determines whether a core > will be chosen for the thread on the socket where the thread ran > previously or on the socket of the waker. This is done primarily by > comparing the load of the

[PATCH v2] sched/fair: check for idle core

2020-10-22 Thread Julia Lawall
In the case of a thread wakeup, wake_affine determines whether a core will be chosen for the thread on the socket where the thread ran previously or on the socket of the waker. This is done primarily by comparing the load of the core where th thread ran previously (prev) and the load of the waker