Re: [PATCH v2] sched/core: Introduce set_next_task() helper for better code readability

2018-11-01 Thread Muchun Song
Hi, Peter Thanks for your review. Just update commit message. So there is no difference between them on the code. Yours, Muchun Song Peter Zijlstra 于2018年11月2日周五 上午12:52写道: > > > > What if anything is the difference with v1 (which I found yesterday and > have pending testing).

Re: [PATCH v2] sched/core: Introduce set_next_task() helper for better code readability

2018-11-01 Thread Peter Zijlstra
What if anything is the difference with v1 (which I found yesterday and have pending testing).

[PATCH v2] sched/core: Introduce set_next_task() helper for better code readability

2018-11-01 Thread Muchun Song
When we pick the next task, we will do the following for the task: 1) p->se.exec_start = rq_clock_task(rq); 2) dequeue_pushable{_dl}_task(rq, p); When we call set_curr_task_{rt,dl}(), we also need to do the same thing above. In rt.c, the code at 1) is in the _pick_next_task_rt() and the code a