Re: [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device

2020-09-02 Thread Nicolas Boichat
On Thu, Sep 3, 2020 at 12:55 AM Mathieu Poirier wrote: > > On Wed, Sep 02, 2020 at 07:07:15PM +0800, Nicolas Boichat wrote: > > If rpmsg_register_device fails, it will call > > mtk_rpmsg_release_device which already frees mdev. > > > > Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 S

Re: [PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device

2020-09-02 Thread Mathieu Poirier
On Wed, Sep 02, 2020 at 07:07:15PM +0800, Nicolas Boichat wrote: > If rpmsg_register_device fails, it will call > mtk_rpmsg_release_device which already frees mdev. > > Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.") The SHA should be 12 characters instead of 15. With that:

[PATCH v2] rpmsg: Avoid double-free in mtk_rpmsg_register_device

2020-09-02 Thread Nicolas Boichat
If rpmsg_register_device fails, it will call mtk_rpmsg_release_device which already frees mdev. Fixes: 7017996951fde84 ("rpmsg: add rpmsg support for mt8183 SCP.") Signed-off-by: Nicolas Boichat --- Changes in v2: - Drop useless if and ret variable (Markus Elfring) drivers/rpmsg/mtk_rpmsg.c |