Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-21 Thread Uwe Kleine-König
On Sat, Feb 20, 2021 at 10:18:27AM +0800, 班涛 wrote: > Uwe Kleine-König 于2021年2月3日周三 下午11:12写道: > > > Hello Ban, > > > > On Wed, Feb 03, 2021 at 08:53:17PM +0800, Ban Tao wrote: > > > v1->v2: > > > > FTR: v1 wasn't sent to any list, so don't try to find it in some > > archive. > > > > Sorry, I un

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-10 Thread Maxime Ripard
On Sat, Feb 06, 2021 at 09:27:30PM +0800, 班涛 wrote: > Maxime Ripard 于2021年2月6日周六 上午12:12写道: > > > Hi, > > > > On Thu, Feb 04, 2021 at 11:47:34AM +0800, 班涛 wrote: > > > Maxime Ripard 于2021年2月3日周三 下午11:46写道: > > > > > > > Hi, > > > > > > > > On Wed, Feb 03, 2021 at 08:53:17PM +0800, Ban Tao wrote:

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-05 Thread Maxime Ripard
Hi, On Thu, Feb 04, 2021 at 11:47:34AM +0800, 班涛 wrote: > Maxime Ripard 于2021年2月3日周三 下午11:46写道: > > > Hi, > > > > On Wed, Feb 03, 2021 at 08:53:17PM +0800, Ban Tao wrote: > > > From: Ban Tao > > > > > > The Allwinner R818, A133, R329, V536 and V833 has a new PWM controller > > > IP compared to

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-04 Thread Thierry Reding
On Thu, Feb 04, 2021 at 02:54:36PM +0100, Uwe Kleine-König wrote: > Hello Thierry, > > On Thu, Feb 04, 2021 at 02:38:40PM +0100, Thierry Reding wrote: > > All I'm saying is that I don't think we need to require everyone to > > adopt a prefix, especially if this hasn't been followed consistently, >

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-04 Thread Uwe Kleine-König
Hello Thierry, On Thu, Feb 04, 2021 at 02:38:40PM +0100, Thierry Reding wrote: > All I'm saying is that I don't think we need to require everyone to > adopt a prefix, especially if this hasn't been followed consistently, > because then we don't actually gain anything. Is "we didn't do this consis

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-04 Thread Thierry Reding
On Wed, Feb 03, 2021 at 09:59:13PM +0100, Uwe Kleine-König wrote: > Hello Thierry, hello Ban, > > On Wed, Feb 03, 2021 at 05:33:16PM +0100, Thierry Reding wrote: > > On Wed, Feb 03, 2021 at 04:12:00PM +0100, Uwe Kleine-König wrote: > > > On Wed, Feb 03, 2021 at 08:53:17PM +0800, Ban Tao wrote: > >

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-03 Thread Uwe Kleine-König
Hello Thierry, hello Ban, On Wed, Feb 03, 2021 at 05:33:16PM +0100, Thierry Reding wrote: > On Wed, Feb 03, 2021 at 04:12:00PM +0100, Uwe Kleine-König wrote: > > On Wed, Feb 03, 2021 at 08:53:17PM +0800, Ban Tao wrote: > [...] > > > +#define PWM_GET_CLK_OFFSET(chan) (0x20 + ((chan >> 1) * 0x4)) >

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-03 Thread Thierry Reding
On Wed, Feb 03, 2021 at 04:12:00PM +0100, Uwe Kleine-König wrote: > On Wed, Feb 03, 2021 at 08:53:17PM +0800, Ban Tao wrote: [...] > > +#define PWM_GET_CLK_OFFSET(chan) (0x20 + ((chan >> 1) * 0x4)) > > +#define PWM_CLK_APB_SCRBIT(7) > > +#define PWM_DIV_M 0 >

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-03 Thread Maxime Ripard
Hi, On Wed, Feb 03, 2021 at 08:53:17PM +0800, Ban Tao wrote: > From: Ban Tao > > The Allwinner R818, A133, R329, V536 and V833 has a new PWM controller > IP compared to the older Allwinner SoCs. > > Signed-off-by: Ban Tao Thanks for your patch. There's a bunch of warnings reported by checkpat

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-03 Thread Uwe Kleine-König
Hello Ban, On Wed, Feb 03, 2021 at 08:53:17PM +0800, Ban Tao wrote: > v1->v2: FTR: v1 wasn't sent to any list, so don't try to find it in some archive. > diff --git a/drivers/pwm/pwm-sun50i.c b/drivers/pwm/pwm-sun50i.c > new file mode 100644 > index ..37285d771924 > --- /dev/null > +

[PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-03 Thread Ban Tao
From: Ban Tao The Allwinner R818, A133, R329, V536 and V833 has a new PWM controller IP compared to the older Allwinner SoCs. Signed-off-by: Ban Tao --- v1->v2: 1.delete unnecessary code. 2.using a named define for some constants. 3.Add comment in sun50i_pwm_config function. 4.using dev_err_pr