RE: [PATCH v2] pmem: fix a name collision

2022-07-12 Thread Dan Williams
Jane Chu wrote: > Kernel test robot detected name collision when compiled on 'um' > architecture. Rename "to_phys()" to "pmem_to_phys()". > > >> drivers/nvdimm/pmem.c:48:20: error: conflicting types for 'to_phys'; have > >> 'phys_addr_t(struct pmem_device *, phys_addr_t)' {aka 'long long unsign

Re: [PATCH v2] pmem: fix a name collision

2022-06-30 Thread Jane Chu
On 6/30/2022 11:29 AM, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig Thank you! -jane

Re: [PATCH v2] pmem: fix a name collision

2022-06-30 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig

[PATCH v2] pmem: fix a name collision

2022-06-30 Thread Jane Chu
Kernel test robot detected name collision when compiled on 'um' architecture. Rename "to_phys()" to "pmem_to_phys()". >> drivers/nvdimm/pmem.c:48:20: error: conflicting types for 'to_phys'; have >> 'phys_addr_t(struct pmem_device *, phys_addr_t)' {aka 'long long unsigned >> int(struct pmem_dev