Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-09 Thread Darren Hart
com; andy.shevche...@gmail.com; > > alex.h...@canonical.com; a...@infradead.org; platform-driver- > > x...@vger.kernel.org; linux-kernel@vger.kernel.org; r...@rjwysocki.net > > Subject: Re: [PATCH v2] platform/x86: intel-hid: Add support for Device > > Specific > &g

RE: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-09 Thread Mario.Limonciello
x...@vger.kernel.org; linux-kernel@vger.kernel.org; r...@rjwysocki.net > Subject: Re: [PATCH v2] platform/x86: intel-hid: Add support for Device > Specific > Methods > > On Mon, Jul 09, 2018 at 04:38:16AM +, mario.limoncie...@dell.com wrote: > > > -Original

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-09 Thread Darren Hart
Limonciello, Mario; Alex Hung; Andy Shevchenko; Platform Driver; Linux > > Kernel > > Mailing List; Rafael J. Wysocki > > Subject: Re: [PATCH v2] platform/x86: intel-hid: Add support for Device > > Specific > > Methods > > > > On Fri, 2018-07-06 at 16:59

RE: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-08 Thread Mario.Limonciello
st; Rafael J. Wysocki > Subject: Re: [PATCH v2] platform/x86: intel-hid: Add support for Device > Specific > Methods > > On Fri, 2018-07-06 at 16:59 -0700, Darren Hart wrote: > > On Mon, Jul 02, 2018 at 05:06:14PM +0300, Andy Shevchenko wrote: > > > On Mon, Jul 2, 2

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-08 Thread Andy Shevchenko
On Sun, Jul 8, 2018 at 2:37 AM, Srinivas Pandruvada wrote: > On Sat, 2018-07-07 at 19:24 +0300, Andy Shevchenko wrote: >> On Sat, Jul 7, 2018 at 6:48 AM, wrote: >> > > I strongly advocate for vendors to have more control over their >> > > drivers, >> > > but this scenario really frustrates me. I

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-07 Thread Srinivas Pandruvada
On Sat, 2018-07-07 at 19:24 +0300, Andy Shevchenko wrote: > On Sat, Jul 7, 2018 at 6:48 AM, wrote: > > > I strongly advocate for vendors to have more control over their > > > drivers, > > > but this scenario really frustrates me. I don't think I can > > > justify this > > > to Linus as a fix. But

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-07 Thread Andy Shevchenko
On Sat, Jul 7, 2018 at 6:48 AM, wrote: >>I strongly advocate for vendors to have more control over their drivers, >>but this scenario really frustrates me. I don't think I can justify this >>to Linus as a fix. But before we just say "no" (because hey, I want >>these fixes available as early as po

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-07 Thread Srinivas Pandruvada
On Fri, 2018-07-06 at 16:59 -0700, Darren Hart wrote: > On Mon, Jul 02, 2018 at 05:06:14PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 2, 2018 at 4:51 PM, > > wrote: > > > > > > > So there are some customers who will have issue with power > > > > > button > > > > > without this patch, so it sh

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-06 Thread Mario.Limonciello
>I strongly advocate for vendors to have more control over their drivers, >but this scenario really frustrates me. I don't think I can justify this >to Linus as a fix. But before we just say "no" (because hey, I want >these fixes available as early as possible too), let's ask Rafael if he >has an o

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-06 Thread Darren Hart
On Mon, Jul 02, 2018 at 05:06:14PM +0300, Andy Shevchenko wrote: > On Mon, Jul 2, 2018 at 4:51 PM, wrote: > > >> > So there are some customers who will have issue with power button > >> > without this patch, so it should be also marked for stable also. > >> > Also this may be a candidate for 4.1

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-02 Thread Andy Shevchenko
On Mon, Jul 2, 2018 at 4:51 PM, wrote: >> > So there are some customers who will have issue with power button >> > without this patch, so it should be also marked for stable also. >> > Also this may be a candidate for 4.18-rcX. >> > >> >> I'm not sure Greg will take this selling point for rather

RE: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-02 Thread Mario.Limonciello
Wysocki > Subject: Re: [PATCH v2] platform/x86: intel-hid: Add support for Device > Specific > Methods > > On Fri, Jun 29, 2018 at 9:41 PM, Srinivas Pandruvada > wrote: > > On Fri, 2018-06-29 at 16:44 +, mario.limoncie...@dell.com wrote: > >> > > >

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-02 Thread Andy Shevchenko
On Fri, Jun 29, 2018 at 9:41 PM, Srinivas Pandruvada wrote: > On Fri, 2018-06-29 at 16:44 +, mario.limoncie...@dell.com wrote: >> > > > [...] > >> I verified this on XPS 9370 FW 1.3.2 (which contains this alternate >> HEBC interface). >> Power button works again for wakeup from s2idle. >> >> T

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-06-29 Thread Srinivas Pandruvada
On Fri, 2018-06-29 at 16:44 +, mario.limoncie...@dell.com wrote: > > [...] > I verified this on XPS 9370 FW 1.3.2 (which contains this alternate > HEBC interface). > Power button works again for wakeup from s2idle. > > Tested-by: Mario Limonciello > So there are some customers who will ha

RE: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-06-29 Thread Mario.Limonciello
kernel.org; > r...@rjwysocki.net; Limonciello, Mario; Srinivas Pandruvada > Subject: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific > Methods > > In some of the recent platforms, it is possible that stand alone methods > for HEBC() or other methods used in this dri

[PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-06-28 Thread Srinivas Pandruvada
In some of the recent platforms, it is possible that stand alone methods for HEBC() or other methods used in this driver may not exist. In this case intel-hid driver will fail to load and power button will not be functional. It is also possible that some quirks in this driver added for some platfo