Re: [PATCH v2] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime

2019-06-10 Thread Nick Crews
A few nits below, and otherwise looks good to me! On Fri, Jun 7, 2019 at 2:51 PM Enric Balletbo Serra wrote: > > Hi, > > Missatge de Guenter Roeck del dia dv., 7 de juny > 2019 a les 22:11: > > > > On Fri, Jun 7, 2019 at 12:27 PM Nick Crews wrote: > > > > > > Hi! > > > > > > On Fri, Jun 7, 2019

Re: [PATCH v2] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime

2019-06-07 Thread Ezequiel Garcia
Hi Enric, On Fri, 2019-06-07 at 22:51 +0200, Enric Balletbo Serra wrote: > Hi, > > Missatge de Guenter Roeck del dia dv., 7 de juny > 2019 a les 22:11: > > On Fri, Jun 7, 2019 at 12:27 PM Nick Crews wrote: > > > Hi! > > > > > > On Fri, Jun 7, 2019 at 12:03 PM Ezequiel Garcia > > > wrote: > >

Re: [PATCH v2] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime

2019-06-07 Thread Enric Balletbo Serra
Hi, Missatge de Guenter Roeck del dia dv., 7 de juny 2019 a les 22:11: > > On Fri, Jun 7, 2019 at 12:27 PM Nick Crews wrote: > > > > Hi! > > > > On Fri, Jun 7, 2019 at 12:03 PM Ezequiel Garcia > > wrote: > > > > > > On Fri, 2019-06-07 at 12:27 +0200, Enric Balletbo i Serra wrote: > > > > On ma

Re: [PATCH v2] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime

2019-06-07 Thread Nick Crews
Actually adding Stefan Reinauer this time... On Fri, Jun 7, 2019 at 1:26 PM Nick Crews wrote: > > Hi! > > On Fri, Jun 7, 2019 at 12:03 PM Ezequiel Garcia > wrote: > > > > On Fri, 2019-06-07 at 12:27 +0200, Enric Balletbo i Serra wrote: > > > On many boards, communication between the kernel and

Re: [PATCH v2] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime

2019-06-07 Thread Guenter Roeck
On Fri, Jun 7, 2019 at 12:27 PM Nick Crews wrote: > > Hi! > > On Fri, Jun 7, 2019 at 12:03 PM Ezequiel Garcia > wrote: > > > > On Fri, 2019-06-07 at 12:27 +0200, Enric Balletbo i Serra wrote: > > > On many boards, communication between the kernel and the Embedded > > > Controller happens over an

Re: [PATCH v2] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime

2019-06-07 Thread Nick Crews
Hi! On Fri, Jun 7, 2019 at 12:03 PM Ezequiel Garcia wrote: > > On Fri, 2019-06-07 at 12:27 +0200, Enric Balletbo i Serra wrote: > > On many boards, communication between the kernel and the Embedded > > Controller happens over an LPC bus. In these cases, the kernel config > > CONFIG_CROS_EC_LPC is

Re: [PATCH v2] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime

2019-06-07 Thread Ezequiel Garcia
On Fri, 2019-06-07 at 12:27 +0200, Enric Balletbo i Serra wrote: > On many boards, communication between the kernel and the Embedded > Controller happens over an LPC bus. In these cases, the kernel config > CONFIG_CROS_EC_LPC is enabled. Some of these LPC boards contain a > Microchip Embedded Contr

[PATCH v2] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime

2019-06-07 Thread Enric Balletbo i Serra
On many boards, communication between the kernel and the Embedded Controller happens over an LPC bus. In these cases, the kernel config CONFIG_CROS_EC_LPC is enabled. Some of these LPC boards contain a Microchip Embedded Controller (MEC) that is different from the regular EC. On these devices, the