Re: [PATCH v2] pipe: Fix memory leaks in create_pipe_files()

2020-10-01 Thread kernel test robot
Hi Qian, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.9-rc7 next-20200930] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in http

Re: [PATCH v2] pipe: Fix memory leaks in create_pipe_files()

2020-09-30 Thread Eric Biggers
On Wed, Sep 30, 2020 at 10:52:55PM -0400, Qian Cai wrote: > diff --git a/include/linux/watch_queue.h b/include/linux/watch_queue.h > index 5e08db2adc31..20665fbe0552 100644 > --- a/include/linux/watch_queue.h > +++ b/include/linux/watch_queue.h > @@ -123,5 +123,9 @@ static inline void remove_watch_

[PATCH v2] pipe: Fix memory leaks in create_pipe_files()

2020-09-30 Thread Qian Cai
Calling pipe2() with O_NOTIFICATION_PIPE could results in memory leaks in an error path or CONFIG_WATCH_QUEUE=n. Plug them. unreferenced object 0xc0141114a0d8 (size 992): comm "trinity-c61", pid 1353192, jiffies 4296255779 (age 25989.560s) hex dump (first 32 bytes): 80 11 00 00 e8 03 0