Re: [PATCH v2] perf test: S390 does not support watchpoints in test 22

2018-09-28 Thread Thomas-Mich Richter
On 09/28/2018 12:17 PM, Ravi Bangoria wrote: > Hi Thomas, > > On 09/28/2018 03:32 PM, Thomas-Mich Richter wrote: >> I can rework the patch to use the is_supported() member function. The >> down side is that the test does not show up in the list of executed tests >> anymore, >> unless some debug o

Re: [PATCH v2] perf test: S390 does not support watchpoints in test 22

2018-09-28 Thread Ravi Bangoria
Hi Thomas, On 09/28/2018 03:32 PM, Thomas-Mich Richter wrote: > I can rework the patch to use the is_supported() member function. The > down side is that the test does not show up in the list of executed tests > anymore, > unless some debug output is enabled: Which should be fine because s390 is

Re: [PATCH v2] perf test: S390 does not support watchpoints in test 22

2018-09-28 Thread Thomas-Mich Richter
On 09/28/2018 10:37 AM, Ravi Bangoria wrote: > Hi Thomas, > > On 09/28/2018 01:13 PM, Thomas Richter wrote: >> diff --git a/tools/perf/tests/builtin-test.c >> b/tools/perf/tests/builtin-test.c >> index 54ca7d87236f..e83c15a95c43 100644 >> --- a/tools/perf/tests/builtin-test.c >> +++ b/tools/perf/

Re: [PATCH v2] perf test: S390 does not support watchpoints in test 22

2018-09-28 Thread Ravi Bangoria
Hi Thomas, On 09/28/2018 01:13 PM, Thomas Richter wrote: > diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c > index 54ca7d87236f..e83c15a95c43 100644 > --- a/tools/perf/tests/builtin-test.c > +++ b/tools/perf/tests/builtin-test.c > @@ -124,7 +124,7 @@ static struct te

[PATCH v2] perf test: S390 does not support watchpoints in test 22

2018-09-28 Thread Thomas Richter
S390 does not support the perf_event_open system call for attribute type PERF_TYPE_BREAKPOINT. This results in test failure for test 22: [root@s8360046 perf]# ./perf test 22 22: Watchpoint: 22.1: Read Only Watchpoint: FAILED! 22.2: Write Only Wat