Re: [PATCH v2] panic: setup panic_timeout early

2013-11-16 Thread Levente Kurusa
2013-11-16 19:46 keltezéssel, Felipe Contreras írta: > On Sat, Nov 16, 2013 at 11:45 AM, Ingo Molnar wrote: >> * Felipe Contreras wrote: > >> Anyway, the fact that you are argumentative even with Linus gives me >> little hope that you will improve your communication patterns with >> _me_, so I'm

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-16 Thread Levente Kurusa
2013-11-16 19:46 keltezéssel, Felipe Contreras írta: > On Sat, Nov 16, 2013 at 11:45 AM, Ingo Molnar wrote: >> * Felipe Contreras wrote: > >> Anyway, the fact that you are argumentative even with Linus gives me >> little hope that you will improve your communication patterns with >> _me_, so I'm

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-16 Thread Felipe Contreras
On Sat, Nov 16, 2013 at 11:45 AM, Ingo Molnar wrote: > * Felipe Contreras wrote: > Anyway, the fact that you are argumentative even with Linus gives me > little hope that you will improve your communication patterns with > _me_, so I'm personally done arguing with you. How am I being argumentat

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-16 Thread Ingo Molnar
* Felipe Contreras wrote: > On Fri, Nov 15, 2013 at 2:15 PM, Linus Torvalds > wrote: > > On Fri, Nov 15, 2013 at 12:10 PM, Felipe Contreras > > wrote: > >> > >> I haven't seen a single complaint about this commit message, so I > >> don't see what is your point. > > > > My point is that I have

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Felipe Contreras
On Fri, Nov 15, 2013 at 2:15 PM, Linus Torvalds wrote: > On Fri, Nov 15, 2013 at 12:10 PM, Felipe Contreras > wrote: >> >> I haven't seen a single complaint about this commit message, so I >> don't see what is your point. > > My point is that I have sixteen pointless messages in my mbox, half of

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Linus Torvalds
On Fri, Nov 15, 2013 at 12:10 PM, Felipe Contreras wrote: > > I haven't seen a single complaint about this commit message, so I > don't see what is your point. My point is that I have sixteen pointless messages in my mbox, half of which are due to just your argumentative nature. In other words,

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Felipe Contreras
On Fri, Nov 15, 2013 at 1:55 PM, Linus Torvalds wrote: > It's not just code. You need to also explain *why* people should apply > it, and stop the f*cking idiotic arguing every time somebody comments > about your patches. Doesn't this explain it?

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Linus Torvalds
On Fri, Nov 15, 2013 at 11:33 AM, Felipe Contreras wrote: > > I am irrelevant, the code is what matter Not so. You are relevant in the sense that you need to communicate why people should take patches from you. I know people who just put you in their kill-files because they can't bother with the

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Felipe Contreras
On Fri, Nov 15, 2013 at 7:12 AM, Levente Kurusa wrote: > No, you don't want timeout to be a long, and instead of kstrtol, you should > use > kstrtoint(char *s, int base, int *res) > which is defined in lib/ktstrtox.c And if you look into kstrtoint() you would see that it's doing *exactly* the s

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Levente Kurusa
2013-11-14 23:32 keltezéssel, Felipe Contreras írta: > Hi, > > Sending again since the previous one was rejected by the server. > > On Thu, Nov 14, 2013 at 3:25 PM, Felipe Contreras > wrote: >> Levente Kurusa wrote: >>> 2013-11-14 12:16 keltezéssel, Felipe Contreras írta: On Tue, Nov 12, 20

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Ingo Molnar
* Felipe Contreras wrote: > On Tue, Nov 12, 2013 at 6:03 PM, Ingo Molnar wrote: > > > >> +static int __init set_panic_timeout(char *val) > >> +{ > >> + long timeout; > >> + int ret; > >> + > >> + ret = kstrtol(val, 0, &timeout); > >> + if (ret < 0) > >> + return ret;

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-14 Thread Felipe Contreras
Hi, Sending again since the previous one was rejected by the server. On Thu, Nov 14, 2013 at 3:25 PM, Felipe Contreras wrote: > Levente Kurusa wrote: >> 2013-11-14 12:16 keltezéssel, Felipe Contreras írta: >> > On Tue, Nov 12, 2013 at 6:03 PM, Ingo Molnar wrote: >> >> >> >> * Felipe Contreras

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-14 Thread Levente Kurusa
2013-11-14 12:16 keltezéssel, Felipe Contreras írta: > On Tue, Nov 12, 2013 at 6:03 PM, Ingo Molnar wrote: >> >> * Felipe Contreras wrote: >> >>> Otherwise we might not reboot when the user needs it the most (early >>> on). >>> >>> Signed-off-by: Felipe Contreras >>> --- >>> >> [...] >>> >>> dif

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-14 Thread Felipe Contreras
On Tue, Nov 12, 2013 at 6:03 PM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> Otherwise we might not reboot when the user needs it the most (early >> on). >> >> Signed-off-by: Felipe Contreras >> --- >> > [...] >> >> diff --git a/kernel/panic.c b/kernel/panic.c >> index b6c482c..d865263

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-12 Thread Ingo Molnar
* Felipe Contreras wrote: > Otherwise we might not reboot when the user needs it the most (early > on). > > Signed-off-by: Felipe Contreras > --- > [...] > > diff --git a/kernel/panic.c b/kernel/panic.c > index b6c482c..d865263 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -468,9

[PATCH v2] panic: setup panic_timeout early

2013-11-11 Thread Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras --- This time using kstrtol() instead of get_option(). Interdiff: diff --git a/kernel/panic.c b/kernel/panic.c index 46e37ff..d865263 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -4