Re: [Ocfs2-devel] [PATCH v2] ocfs2: fix a static checker warning

2017-05-23 Thread Eric Ren
On 05/23/2017 01:17 PM, Gang He wrote: This patch will fix a static code checker warning, which looks like below, fs/ocfs2/inode.c:179 ocfs2_iget() warn: passing zero to 'ERR_PTR' this warning was caused by the commit d56a8f32e4c6 ("ocfs2: check/fix inode block for online file check"). after app

Re: [PATCH v2] ocfs2: fix a static checker warning

2017-05-23 Thread Gang He
Hello Andrew, I am sorry that I did not write which static code checker tool, since I did not get the name from Dan, I think the tool should be like Coverity code checking tool. Second, set the initial value of local variable rc to -ESTALE from zero, this change will make the code logic is stri

Re: [PATCH v2] ocfs2: fix a static checker warning

2017-05-23 Thread Andrew Morton
On Tue, 23 May 2017 13:17:14 +0800 Gang He wrote: > This patch will fix a static code checker warning, which looks > like below, > fs/ocfs2/inode.c:179 ocfs2_iget() > warn: passing zero to 'ERR_PTR' > > this warning was caused by the > commit d56a8f32e4c6 ("ocfs2: check/fix inode block for onl

[PATCH v2] ocfs2: fix a static checker warning

2017-05-22 Thread Gang He
This patch will fix a static code checker warning, which looks like below, fs/ocfs2/inode.c:179 ocfs2_iget() warn: passing zero to 'ERR_PTR' this warning was caused by the commit d56a8f32e4c6 ("ocfs2: check/fix inode block for online file check"). after apply this patch, the error return value w