Re: [PATCH v2] nvme: use uuid_t in nvme_ns

Reviewed-by: Sagi Grimberg

Re: [PATCH v2] nvme: use uuid_t in nvme_ns

On Mon, Jun 12, 2017 at 11:12:40AM +0200, Johannes Thumshirn wrote: > struct nvme_ns still uses u u8 uuid[16], change it to using uuid_t and > use the UUID API. > > Signed-off-by: Johannes Thumshirn Thanks, folded into the two patches originall introducing the code.

Re: [PATCH v2] nvme: use uuid_t in nvme_ns

On Mon, Jun 12, 2017 at 2:03 PM, Christoph Hellwig wrote: > On Mon, Jun 12, 2017 at 12:04:18PM +0200, Johannes Thumshirn wrote: >> > So, this reveals two thins: >> > 1) shall we define NVME_NIDT_UUID_LEN to be UUID_LEN or substitute it >> > completely with the latter? >> >> No, we have NVME_NIDT_U

Re: [PATCH v2] nvme: use uuid_t in nvme_ns

On Mon, Jun 12, 2017 at 12:04:18PM +0200, Johannes Thumshirn wrote: > > So, this reveals two thins: > > 1) shall we define NVME_NIDT_UUID_LEN to be UUID_LEN or substitute it > > completely with the latter? > > No, we have NVME_NIDT_UUID_LEN but also NVME_NIDT_NGUID_LEN and > NVME_NIDT_EUI64_LEN.

Re: [PATCH v2] nvme: use uuid_t in nvme_ns

On 06/12/2017 11:50 AM, Andy Shevchenko wrote: >> len = NVME_NIDT_UUID_LEN; >> - memcpy(ns->uuid, data + pos + sizeof(*cur), len); >> + uuid_copy(&ns->uuid, data + pos + sizeof(*cur)); > > So, this reveals two thins: > 1) shall we

Re: [PATCH v2] nvme: use uuid_t in nvme_ns

On Mon, Jun 12, 2017 at 12:12 PM, Johannes Thumshirn wrote: > struct nvme_ns still uses u u8 uuid[16], change it to using uuid_t and > use the UUID API. Thanks for an update. See my further comments below. > len = NVME_NIDT_UUID_LEN; > - memcpy(ns->

[PATCH v2] nvme: use uuid_t in nvme_ns

struct nvme_ns still uses u u8 uuid[16], change it to using uuid_t and use the UUID API. Signed-off-by: Johannes Thumshirn --- drivers/nvme/host/core.c | 8 drivers/nvme/host/nvme.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers