Re: [PATCH v2] nvme: Use spin_lock_irq() when taking the ctrl->lock

2020-08-13 Thread Sagi Grimberg
There's an unrelated whitespace change in nvme_init_identify(). Otherwise, looks fine. Oops, sorry. can this be fixed up when it's merged? Fixed and queued.

Re: [PATCH v2] nvme: Use spin_lock_irq() when taking the ctrl->lock

2020-08-12 Thread Logan Gunthorpe
On 2020-08-12 6:32 p.m., Keith Busch wrote: > There's an unrelated whitespace change in nvme_init_identify(). > Otherwise, looks fine. Oops, sorry. can this be fixed up when it's merged? Logan

Re: [PATCH v2] nvme: Use spin_lock_irq() when taking the ctrl->lock

2020-08-12 Thread Chaitanya Kulkarni
On 8/12/20 16:25, Logan Gunthorpe wrote: > When locking the ctrl->lock spinlock IRQs need to be disabled to avoid a > dead lock. The new spin_lock() calls recently added produce the > following lockdep warning when running the blktest nvme/003: > > > WARN

Re: [PATCH v2] nvme: Use spin_lock_irq() when taking the ctrl->lock

2020-08-12 Thread Keith Busch
There's an unrelated whitespace change in nvme_init_identify(). Otherwise, looks fine. Reviewed-by: Keith Busch

[PATCH v2] nvme: Use spin_lock_irq() when taking the ctrl->lock

2020-08-12 Thread Logan Gunthorpe
When locking the ctrl->lock spinlock IRQs need to be disabled to avoid a dead lock. The new spin_lock() calls recently added produce the following lockdep warning when running the blktest nvme/003: WARNING: inconsistent lock state --