Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-04-08 Thread J. Bruce Fields
On Mon, Apr 08, 2013 at 09:54:18PM +0800, Yanchuan Nian wrote: > On Fri, Apr 05, 2013 at 10:20:42AM -0400, J. Bruce Fields wrote: > > Actually, I find encode_seqid_op_tail completely confusing, and I don't > > see why it's necessary--it would seem more straightforward to do the > > seqid bump in th

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-04-08 Thread Yanchuan Nian
On Fri, Apr 05, 2013 at 10:20:42AM -0400, J. Bruce Fields wrote: > On Thu, Apr 04, 2013 at 10:04:03PM +0800, Yanchuan Nian wrote: > > On Wed, Apr 03, 2013 at 02:55:08PM -0400, J. Bruce Fields wrote: > > > On Wed, Apr 03, 2013 at 06:58:43PM +0800, Yanchuan Nian wrote: > > > > On Mon, Apr 01, 2013 at

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-04-05 Thread J. Bruce Fields
On Thu, Apr 04, 2013 at 10:04:03PM +0800, Yanchuan Nian wrote: > On Wed, Apr 03, 2013 at 02:55:08PM -0400, J. Bruce Fields wrote: > > On Wed, Apr 03, 2013 at 06:58:43PM +0800, Yanchuan Nian wrote: > > > On Mon, Apr 01, 2013 at 09:50:44PM -0400, J. Bruce Fields wrote: > > > > On Wed, Mar 13, 2013 at

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-04-04 Thread Yanchuan Nian
On Wed, Apr 03, 2013 at 02:55:08PM -0400, J. Bruce Fields wrote: > On Wed, Apr 03, 2013 at 06:58:43PM +0800, Yanchuan Nian wrote: > > On Mon, Apr 01, 2013 at 09:50:44PM -0400, J. Bruce Fields wrote: > > > On Wed, Mar 13, 2013 at 11:04:54PM +0800, Yanchuan Nian wrote: > > > > 2013/3/11 J. Bruce Fiel

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-04-03 Thread J. Bruce Fields
On Wed, Apr 03, 2013 at 06:58:43PM +0800, Yanchuan Nian wrote: > On Mon, Apr 01, 2013 at 09:50:44PM -0400, J. Bruce Fields wrote: > > On Wed, Mar 13, 2013 at 11:04:54PM +0800, Yanchuan Nian wrote: > > > 2013/3/11 J. Bruce Fields > > > > > > > On Mon, Mar 11, 2013 at 08:46:14AM +0800, ycn...@gmail

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-04-03 Thread Yanchuan Nian
On Mon, Apr 01, 2013 at 09:50:44PM -0400, J. Bruce Fields wrote: > On Wed, Mar 13, 2013 at 11:04:54PM +0800, Yanchuan Nian wrote: > > 2013/3/11 J. Bruce Fields > > > > > On Mon, Mar 11, 2013 at 08:46:14AM +0800, ycn...@gmail.com wrote: > > > > NFS4_OO_PURGE_CLOSE is not handled properly. To avoid

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-04-01 Thread J. Bruce Fields
On Wed, Mar 13, 2013 at 11:04:54PM +0800, Yanchuan Nian wrote: > 2013/3/11 J. Bruce Fields > > > On Mon, Mar 11, 2013 at 08:46:14AM +0800, ycn...@gmail.com wrote: > > > NFS4_OO_PURGE_CLOSE is not handled properly. To avoid memory leak, nfs4 > > > stateid which is pointed by oo_last_closed_stid is

Re: [PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-03-11 Thread J. Bruce Fields
On Mon, Mar 11, 2013 at 08:46:14AM +0800, ycn...@gmail.com wrote: > NFS4_OO_PURGE_CLOSE is not handled properly. To avoid memory leak, nfs4 > stateid which is pointed by oo_last_closed_stid is freed in nfsd4_close(), > but NFS4_OO_PURGE_CLOSE isn't cleared meanwhile. So the stateid released in >

[PATCH v2] nfsd: fix bug on nfs4 stateid deallocation

2013-03-10 Thread ycnian
NFS4_OO_PURGE_CLOSE is not handled properly. To avoid memory leak, nfs4 stateid which is pointed by oo_last_closed_stid is freed in nfsd4_close(), but NFS4_OO_PURGE_CLOSE isn't cleared meanwhile. So the stateid released in THIS close procedure may be freed immediately in the coming encoding func