Re: [PATCH v2] nfs: remove incorrect fallthrough label

2020-09-17 Thread Joe Perches
On Thu, 2020-09-17 at 14:41 -0700, Nick Desaulniers wrote: > On Wed, Sep 16, 2020 at 1:19 PM Joe Perches wrote: > > On Wed, 2020-09-16 at 13:02 -0700, Nick Desaulniers wrote: > > > * (call of function with __attribute__(__noreturn__)) > > > > I guess panic counts. I count 11 of those. > > > > A

Re: [PATCH v2] nfs: remove incorrect fallthrough label

2020-09-17 Thread Nick Desaulniers
On Wed, Sep 16, 2020 at 1:19 PM Joe Perches wrote: > > On Wed, 2020-09-16 at 13:02 -0700, Nick Desaulniers wrote: > > * (call of function with __attribute__(__noreturn__)) > > I guess panic counts. I count 11 of those. > > Are there any other uses of functions with __noreturn > in switch/case lab

Re: [PATCH v2] nfs: remove incorrect fallthrough label

2020-09-16 Thread linmiaohe
Nick Desaulniers wrote: > There is no case after the default from which to fallthrough to. Clang will > error in this case (unhelpfully without context, see link below) and GCC will > with -Wswitch-unreachable. > >The previous commit should have just replaced the comment with a break >statement

Re: [PATCH v2] nfs: remove incorrect fallthrough label

2020-09-16 Thread Nathan Chancellor
On Wed, Sep 16, 2020 at 01:02:55PM -0700, Nick Desaulniers wrote: > There is no case after the default from which to fallthrough to. Clang > will error in this case (unhelpfully without context, see link below) > and GCC will with -Wswitch-unreachable. > > The previous commit should have just repl

Re: [PATCH v2] nfs: remove incorrect fallthrough label

2020-09-16 Thread Joe Perches
On Wed, 2020-09-16 at 13:02 -0700, Nick Desaulniers wrote: > There is no case after the default from which to fallthrough to. Clang > will error in this case (unhelpfully without context, see link below) > and GCC will with -Wswitch-unreachable. > > The previous commit should have just replaced th

Re: [PATCH v2] nfs: remove incorrect fallthrough label

2020-09-16 Thread Gustavo A. R. Silva
On Wed, Sep 16, 2020 at 01:02:55PM -0700, Nick Desaulniers wrote: > There is no case after the default from which to fallthrough to. Clang > will error in this case (unhelpfully without context, see link below) > and GCC will with -Wswitch-unreachable. > > The previous commit should have just repl

[PATCH v2] nfs: remove incorrect fallthrough label

2020-09-16 Thread Nick Desaulniers
There is no case after the default from which to fallthrough to. Clang will error in this case (unhelpfully without context, see link below) and GCC will with -Wswitch-unreachable. The previous commit should have just replaced the comment with a break statement. If we consider implicit fallthroug