Re: [PATCH v2] net: mdio: switch to using gpiod_get_optional()

2019-09-15 Thread Andy Shevchenko
On Sun, Sep 15, 2019 at 9:26 AM Dmitry Torokhov wrote: > On Sat, Sep 14, 2019 at 08:09:33PM +0300, Andy Shevchenko wrote: > > On Fri, Sep 13, 2019 at 03:55:47PM -0700, Dmitry Torokhov wrote: > > > + mdiodev->reset_gpio = gpiod_get_optional(&mdiodev->dev, > > > +

Re: [PATCH v2] net: mdio: switch to using gpiod_get_optional()

2019-09-14 Thread Dmitry Torokhov
On Sat, Sep 14, 2019 at 08:09:33PM +0300, Andy Shevchenko wrote: > On Fri, Sep 13, 2019 at 03:55:47PM -0700, Dmitry Torokhov wrote: > > The MDIO device reset line is optional and now that gpiod_get_optional() > > returns proper value when GPIO support is compiled out, there is no > > reason to use

Re: [PATCH v2] net: mdio: switch to using gpiod_get_optional()

2019-09-14 Thread Andy Shevchenko
On Fri, Sep 13, 2019 at 03:55:47PM -0700, Dmitry Torokhov wrote: > The MDIO device reset line is optional and now that gpiod_get_optional() > returns proper value when GPIO support is compiled out, there is no > reason to use fwnode_get_named_gpiod() that I plan to hide away. > > Let's switch to u

Re: [PATCH v2] net: mdio: switch to using gpiod_get_optional()

2019-09-14 Thread Andrew Lunn
On Fri, Sep 13, 2019 at 03:55:47PM -0700, Dmitry Torokhov wrote: > The MDIO device reset line is optional and now that gpiod_get_optional() > returns proper value when GPIO support is compiled out, there is no > reason to use fwnode_get_named_gpiod() that I plan to hide away. > > Let's switch to u

[PATCH v2] net: mdio: switch to using gpiod_get_optional()

2019-09-13 Thread Dmitry Torokhov
The MDIO device reset line is optional and now that gpiod_get_optional() returns proper value when GPIO support is compiled out, there is no reason to use fwnode_get_named_gpiod() that I plan to hide away. Let's switch to using more standard gpiod_get_optional() and gpiod_set_consumer_name() to ke