Re: [PATCH v2] net/mlx5e: fix bpf_prog reference count leaks in mlx5e_alloc_rq

On Thu, 2020-07-30 at 18:29 +0800, Xin Xiong wrote: > The function invokes bpf_prog_inc(), which increases the reference > count of a bpf_prog object "rq->xdp_prog" if the object isn't NULL. > > The refcount leak issues take place in two error handling paths. When > either mlx5_wq_ll_create() or m

Re: [PATCH v2] net/mlx5e: fix bpf_prog reference count leaks in mlx5e_alloc_rq

On Thu, 30 Jul 2020 18:29:41 +0800 Xin Xiong wrote: > Fixes: 422d4c401edd ("net/mlx5e: RX, Split WQ objects for different RQ > types") > > Signed-off-by: Xin Xiong > Signed-off-by: Xiyu Yang > Signed-off-by: Xin Tan Thanks for the patch, please make sure Fixes tag is not line-wrapped and there

[PATCH v2] net/mlx5e: fix bpf_prog reference count leaks in mlx5e_alloc_rq

The function invokes bpf_prog_inc(), which increases the reference count of a bpf_prog object "rq->xdp_prog" if the object isn't NULL. The refcount leak issues take place in two error handling paths. When either mlx5_wq_ll_create() or mlx5_wq_cyc_create() fails, the function simply returns the err