Re: [Nbd] [PATCH v2] nbd: fix possible memory leak

2015-01-28 Thread Markus Pargmann
On Tue, Jan 27, 2015 at 06:08:22PM +0530, Sudip Mukherjee wrote: > we have already allocated memory for nbd_dev, but we were not > releasing that memory and just returning the error value. > > Signed-off-by: Sudip Mukherjee Thanks, applied. Regards, Markus -- Pengutronix e.K.

Re: [PATCH v2] nbd: fix possible memory leak

2015-01-27 Thread Paul Clements
On Tue, Jan 27, 2015 at 7:38 AM, Sudip Mukherjee wrote: > we have already allocated memory for nbd_dev, but we were not > releasing that memory and just returning the error value. > > Signed-off-by: Sudip Mukherjee Looks good to me. Acked-by: Paul Clements > --- > > v2: moved kcalloc after th

[PATCH v2] nbd: fix possible memory leak

2015-01-27 Thread Sudip Mukherjee
we have already allocated memory for nbd_dev, but we were not releasing that memory and just returning the error value. Signed-off-by: Sudip Mukherjee --- v2: moved kcalloc after the returns. drivers/block/nbd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driver