Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-16 Thread Viet Nga Dao
On Fri, Mar 13, 2015 at 3:38 PM, Brian Norris wrote: > Hi Viet, > > On Wed, Feb 11, 2015 at 12:53:00PM +0800, Viet Nga Dao wrote: >> From: Viet Nga Dao >> >> Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and >> EPCS flash chips. This patch adds driver for these devices.

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-13 Thread Viet Nga Dao
Hi Brian, Thanks for your detail comment. I will make modification and submit the separated patches On Fri, Mar 13, 2015 at 3:38 PM, Brian Norris wrote: > Hi Viet, > > On Wed, Feb 11, 2015 at 12:53:00PM +0800, Viet Nga Dao wrote: >> From: Viet Nga Dao >> >> Altera EPCQ Controller is a soft IP wh

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-13 Thread Brian Norris
Hi Viet, On Wed, Feb 11, 2015 at 12:53:00PM +0800, Viet Nga Dao wrote: > From: Viet Nga Dao > > Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and > EPCS flash chips. This patch adds driver for these devices. > > Signed-off-by: VIET NGA DAO > > --- > v2: > - Change to

Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-12 Thread Viet Nga Dao
On Fri, Mar 13, 2015 at 1:45 PM, Rafał Miłecki wrote: > On 11 March 2015 at 09:41, Viet Nga Dao wrote: >> On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrote: >>> Ok. I will modify the code the way you suggest. >> >> I just realize that the opcode for RDID is handled by hardware in my >> case, t

Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-12 Thread Rafał Miłecki
On 11 March 2015 at 09:41, Viet Nga Dao wrote: > On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrote: >> Ok. I will modify the code the way you suggest. > > I just realize that the opcode for RDID is handled by hardware in my > case, therefore i dont really need to worry about 0xab opcode. Nice

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-12 Thread Viet Nga Dao
Hi, Could anyone please help me review the lock, unlock modification part i did in spi-nor? Thanks, Viet Nga On Mon, Feb 23, 2015 at 9:30 AM, Viet Nga Dao wrote: > Hi, > It has been nearly 2 weeks since i submitted this patch. Could you > please help to review? > Thanks, > > On Tue, Feb 17, 2015

Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-11 Thread Viet Nga Dao
Hi Rafal, On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrote: > + > +/* Altera EPCQ/EPCS Flashes */ > +{ "epcq16" , EPCQ_INFO(2, 0x15, 0x1, 32, 0x100) }, > +{ "epcq32" , EPCQ_INFO(2, 0x16, 0x1, 64, 0x100) }, > +{ "epcq64" , EPCQ_INFO(2, 0x17, 0x

Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-10 Thread Viet Nga Dao
+ +/* Altera EPCQ/EPCS Flashes */ +{ "epcq16" , EPCQ_INFO(2, 0x15, 0x1, 32, 0x100) }, +{ "epcq32" , EPCQ_INFO(2, 0x16, 0x1, 64, 0x100) }, +{ "epcq64" , EPCQ_INFO(2, 0x17, 0x1, 128, 0x100) }, +{ "epcq128" , EPCQ_INFO(2, 0x18, 0x10

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-09 Thread Rafał Miłecki
On 10 March 2015 at 07:11, Viet Nga Dao wrote: > On Mon, Mar 9, 2015 at 2:31 PM, Rafał Miłecki wrote: >> On 11 February 2015 at 05:53, Viet Nga Dao wrote: >>> /* NOTE: double check command sets and memory organization when you add >>> * more nor chips. This current list focusses on newer chi

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-09 Thread Viet Nga Dao
Hi Rafal, Thanks for your review. On Mon, Mar 9, 2015 at 2:31 PM, Rafał Miłecki wrote: > Hi Viet, > > I'm not too active in mtd subsystem, so I didn't notice your patch > earlier. However I would like to share few comments. > > On 11 February 2015 at 05:53, Viet Nga Dao wrote: >> From: Viet Nga

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-08 Thread Rafał Miłecki
Hi Viet, I'm not too active in mtd subsystem, so I didn't notice your patch earlier. However I would like to share few comments. On 11 February 2015 at 05:53, Viet Nga Dao wrote: > From: Viet Nga Dao > > Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and > EPCS flash ch

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-08 Thread Viet Nga Dao
Hi Brian, I understand that you are busy but is it possible if you could spend some time to help me review my patch? My work progress really depends on your review. Thanks, Viet Nga On Tue, Feb 24, 2015 at 11:59 AM, Brian Norris wrote: > On Mon, Feb 23, 2015 at 09:30:09AM +0800, Viet Nga Dao wrot

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-02-23 Thread Brian Norris
On Mon, Feb 23, 2015 at 09:30:09AM +0800, Viet Nga Dao wrote: > Hi, > It has been nearly 2 weeks since i submitted this patch. Could you > please help to review? Those two weeks were during the merge window, so I wasn't queueing anything up. And there are things that have waited longer, anyway. M

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-02-22 Thread Viet Nga Dao
Hi, It has been nearly 2 weeks since i submitted this patch. Could you please help to review? Thanks, On Tue, Feb 17, 2015 at 9:33 AM, Viet Nga Dao wrote: > Hi Brian, > Could you please help me to review through this 2nd version? > > On Wed, Feb 11, 2015 at 12:53 PM, Viet Nga Dao wrote: >> From

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-02-16 Thread Viet Nga Dao
Hi Brian, Could you please help me to review through this 2nd version? On Wed, Feb 11, 2015 at 12:53 PM, Viet Nga Dao wrote: > From: Viet Nga Dao > > Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and > EPCS flash chips. This patch adds driver for these devices. > > Sign

[PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-02-10 Thread Viet Nga Dao
From: Viet Nga Dao Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and EPCS flash chips. This patch adds driver for these devices. Signed-off-by: VIET NGA DAO --- v2: - Change to spi_nor structure - Add lock and unlock functions for spi_nor - Simplify the altera_epcq_lo