Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

Hi Miquel, On 2019/6/28 AM2:17, Miquel Raynal wrote: > Hi Miquel, > > Miquel Raynal wrote on Thu, 27 Jun 2019 > 19:06:44 +0200: > >> Hello, >> >> Schrempf Frieder wrote on Tue, 25 Jun >> 2019 07:04:06 +: >> >>> Hi liaoweixiong, >>> >>> On 25.06.19 05:08, Greg KH wrote: On Tue, Jun 2

Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

Hi Miquel, Miquel Raynal wrote on Thu, 27 Jun 2019 19:06:44 +0200: > Hello, > > Schrempf Frieder wrote on Tue, 25 Jun > 2019 07:04:06 +: > > > Hi liaoweixiong, > > > > On 25.06.19 05:08, Greg KH wrote: > > > On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: > > >> In ca

Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

Hello, Schrempf Frieder wrote on Tue, 25 Jun 2019 07:04:06 +: > Hi liaoweixiong, > > On 25.06.19 05:08, Greg KH wrote: > > On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: > >> In case of the last page containing bitflips (ret > 0), > >> spinand_mtd_read() will return that nu

Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

On 25.06.19 13:56, liaoweixiong wrote: > Oh, i am sorry that i had misunderstanded your letter. No problem ;) > Thank you for your document and guidance. You're welcome! > On 2019/6/25 PM 3:04, Schrempf Frieder wrote: >> Hi liaoweixiong, >> >> On 25.06.19 05:08, Greg KH wrote: >>> On Tue, Jun 2

[RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

In case of the last page containing bitflips (ret > 0), spinand_mtd_read() will return that number of bitflips for the last page. But to me it looks like it should instead return max_bitflips like it does when the last page read returns with 0. Signed-off-by: liaoweixiong Reviewed-by: Boris Brezi

Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

Oh, i am sorry that i had misunderstanded your letter. Thank you for your document and guidance. On 2019/6/25 PM 3:04, Schrempf Frieder wrote: > Hi liaoweixiong, > > On 25.06.19 05:08, Greg KH wrote: >> On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: >>> In case of the last page con

Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

Hi liaoweixiong, On 25.06.19 05:08, Greg KH wrote: > On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: >> In case of the last page containing bitflips (ret > 0), >> spinand_mtd_read() will return that number of bitflips for the last >> page. But to me it looks like it should instead re

Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: > In case of the last page containing bitflips (ret > 0), > spinand_mtd_read() will return that number of bitflips for the last > page. But to me it looks like it should instead return max_bitflips like > it does when the last page read

[RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

In case of the last page containing bitflips (ret > 0), spinand_mtd_read() will return that number of bitflips for the last page. But to me it looks like it should instead return max_bitflips like it does when the last page read returns with 0. Signed-off-by: liaoweixiong Reviewed-by: Boris Brezi

Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

Um.. I am sorry. It is the first time for me to resend patch. I will send this patch again with correct tags. On 2019/6/24 PM10:47, Schrempf Frieder wrote: > On 24.06.19 14:15, liaoweixiong wrote: >> In case of the last page containing bitflips (ret > 0), >> spinand_mtd_read() will return that num

Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

On 24.06.19 14:15, liaoweixiong wrote: > In case of the last page containing bitflips (ret > 0), > spinand_mtd_read() will return that number of bitflips for the last > page. But to me it looks like it should instead return max_bitflips like > it does when the last page read returns with 0. > > Si

[RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

In case of the last page containing bitflips (ret > 0), spinand_mtd_read() will return that number of bitflips for the last page. But to me it looks like it should instead return max_bitflips like it does when the last page read returns with 0. Signed-off-by: liaoweixiong Acked-by: Boris Brezillo

Re: [PATCH v2] mtd: spinand: read return badly if the last page has bitflips

OK, thanks for your reviewing. I will resend right now. On 2019/6/24 PM3:37, Schrempf Frieder wrote: > On 20.06.19 03:00, liaoweixiong wrote: >> In case of the last page containing bitflips (ret > 0), >> spinand_mtd_read() will return that number of bitflips for the last >> page. But to me it look

Re: [PATCH v2] mtd: spinand: read return badly if the last page has bitflips

On 20.06.19 03:00, liaoweixiong wrote: > In case of the last page containing bitflips (ret > 0), > spinand_mtd_read() will return that number of bitflips for the last > page. But to me it looks like it should instead return max_bitflips like > it does when the last page read returns with 0. > > Si

Re: [PATCH v2] mtd: spinand: read return badly if the last page has bitflips

On Thu, 20 Jun 2019 09:00:16 +0800 liaoweixiong wrote: > In case of the last page containing bitflips (ret > 0), > spinand_mtd_read() will return that number of bitflips for the last > page. But to me it looks like it should instead return max_bitflips like > it does when the last page read retur

[PATCH v2] mtd: spinand: read return badly if the last page has bitflips

In case of the last page containing bitflips (ret > 0), spinand_mtd_read() will return that number of bitflips for the last page. But to me it looks like it should instead return max_bitflips like it does when the last page read returns with 0. Signed-off-by: liaoweixiong --- drivers/mtd/nand/sp