Re: [PATCH v2] mtd: orion_nand: Improve error handling in orion_nand_probe

2013-06-10 Thread Emil Goode
Hello Jingoo, Thank you for the review. There was another discussion and the following patch was sent that converts printk to dev_err. http://lists.infradead.org/pipermail/linux-mtd/2013-June/047198.html My conclusion of the discussion was that error messages for kzalloc calls are probably made

Re: [PATCH v2] mtd: orion_nand: Improve error handling in orion_nand_probe

2013-06-09 Thread Jingoo Han
Monday, June 10, 2013 9:01 AM, Emil Goode wrote: > > This patch fixes some issues in the error handling and simplifies > the code by converting to devm* functions. > > If the kzalloc call fails it is unnecessary to use the label no_res > and pass a NULL pointer to kfree. If the devm_kzalloc call

[PATCH v2] mtd: orion_nand: Improve error handling in orion_nand_probe

2013-06-09 Thread Emil Goode
This patch fixes some issues in the error handling and simplifies the code by converting to devm* functions. If the kzalloc call fails it is unnecessary to use the label no_res and pass a NULL pointer to kfree. If the devm_kzalloc call fails on line 110 we forget to call iounmap for the previous i