Re: [PATCH v2] mtd: cmdlinepart: fix the wrong check condition

2012-09-02 Thread Artem Bityutskiy
On Sat, 2012-08-25 at 12:31 +0300, Shmulik Ladkani wrote: > Hi Huang, Artem, > > On Sat, 25 Aug 2012 16:06:50 -0400 Huang Shijie wrote: > > diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c > > index fc960a3..216d751 100644 > > --- a/drivers/mtd/cmdlinepart.c > > +++ b/drivers/mt

Re: [PATCH v2] mtd: cmdlinepart: fix the wrong check condition

2012-08-26 Thread Huang Shijie
On Sat, Aug 25, 2012 at 5:31 AM, Shmulik Ladkani wrote: > Hi Huang, Artem, > > On Sat, 25 Aug 2012 16:06:50 -0400 Huang Shijie wrote: >> diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c >> index fc960a3..216d751 100644 >> --- a/drivers/mtd/cmdlinepart.c >> +++ b/drivers/mtd/cmdl

Re: [PATCH v2] mtd: cmdlinepart: fix the wrong check condition

2012-08-25 Thread Shmulik Ladkani
Hi Huang, Artem, On Sat, 25 Aug 2012 16:06:50 -0400 Huang Shijie wrote: > diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c > index fc960a3..216d751 100644 > --- a/drivers/mtd/cmdlinepart.c > +++ b/drivers/mtd/cmdlinepart.c > @@ -322,13 +322,16 @@ static int parse_cmdline_partiti

[PATCH v2] mtd: cmdlinepart: fix the wrong check condition

2012-08-25 Thread Huang Shijie
The `mtd_id` is set by the name of a mtd device driver. As a nand controller driver, even we do not set the @name of the mtd_info{}, the nand_get_flash_type() will set it with the nand type's name. So the `mtd_id` can never be NULL in this case. But as a nor controller driver which may does not c