Re: [PATCH v2] msi: free msi_desc entry only after we've released the kobject

2013-10-09 Thread Veaceslav Falico
On Fri, Oct 04, 2013 at 10:46:31AM -0600, Bjorn Helgaas wrote: On Sat, Sep 28, 2013 at 3:37 PM, Veaceslav Falico wrote: On Thu, Sep 26, 2013 at 11:59:51AM +0200, Veaceslav Falico wrote: Currently, we first do kobject_put(&entry->kobj) and the kfree(entry), however kobject_put() doesn't guaran

Re: [PATCH v2] msi: free msi_desc entry only after we've released the kobject

2013-10-04 Thread Bjorn Helgaas
On Sat, Sep 28, 2013 at 3:37 PM, Veaceslav Falico wrote: > On Thu, Sep 26, 2013 at 11:59:51AM +0200, Veaceslav Falico wrote: >> >> Currently, we first do kobject_put(&entry->kobj) and the kfree(entry), >> however kobject_put() doesn't guarantee us that it was the last reference >> and that the kob

Re: [PATCH v2] msi: free msi_desc entry only after we've released the kobject

2013-10-03 Thread Bjorn Helgaas
On Wed, Oct 2, 2013 at 2:41 PM, Russell King - ARM Linux wrote: > On Mon, Sep 30, 2013 at 10:53:46PM -0700, Bjorn Helgaas wrote: >> I think the current kobject delayed release is too aggressive, > > I don't agree with that statement, but the rest of the sentence I do: I think you're right. I thi

Re: [PATCH v2] msi: free msi_desc entry only after we've released the kobject

2013-10-02 Thread Russell King - ARM Linux
On Mon, Sep 30, 2013 at 10:53:46PM -0700, Bjorn Helgaas wrote: > I think the current kobject delayed release is too aggressive, I don't agree with that statement, but the rest of the sentence I do: > in the > sense that even after we've released all references, the object can > still be in sysfs,

Re: [PATCH v2] msi: free msi_desc entry only after we've released the kobject

2013-09-30 Thread Bjorn Helgaas
[+cc Russell] On Sat, Sep 28, 2013 at 11:37:27PM +0200, Veaceslav Falico wrote: > On Thu, Sep 26, 2013 at 11:59:51AM +0200, Veaceslav Falico wrote: > >Currently, we first do kobject_put(&entry->kobj) and the kfree(entry), > >however kobject_put() doesn't guarantee us that it was the last reference

Re: [PATCH v2] msi: free msi_desc entry only after we've released the kobject

2013-09-28 Thread Veaceslav Falico
On Thu, Sep 26, 2013 at 11:59:51AM +0200, Veaceslav Falico wrote: Currently, we first do kobject_put(&entry->kobj) and the kfree(entry), however kobject_put() doesn't guarantee us that it was the last reference and that the kobj isn't used currently by someone else, so after we kfree(entry) with

Re: [PATCH v2] msi: free msi_desc entry only after we've released the kobject

2013-09-26 Thread Neil Horman
On Thu, Sep 26, 2013 at 11:59:51AM +0200, Veaceslav Falico wrote: > Currently, we first do kobject_put(&entry->kobj) and the kfree(entry), > however kobject_put() doesn't guarantee us that it was the last reference > and that the kobj isn't used currently by someone else, so after we > kfree(entry)

[PATCH v2] msi: free msi_desc entry only after we've released the kobject

2013-09-26 Thread Veaceslav Falico
Currently, we first do kobject_put(&entry->kobj) and the kfree(entry), however kobject_put() doesn't guarantee us that it was the last reference and that the kobj isn't used currently by someone else, so after we kfree(entry) with the struct kobject - other users will begin using the freed memory,