Re: [PATCH v2] mmc: pxamci: fix card detect with slot-gpio API

2015-09-17 Thread Robert Jarzmik
Ulf Hansson writes: >> + if (gpio_is_valid(gpio_ro)) >> + ret = mmc_gpio_request_ro(mmc, gpio_ro); > > Would it be possible for you to use the mmc_gpiod_request_ro() instead? I don't think so. Most of pxamci users are old platform data based machine code, which passes an integ

Re: [PATCH v2] mmc: pxamci: fix card detect with slot-gpio API

2015-09-17 Thread Ulf Hansson
On 16 September 2015 at 21:16, Robert Jarzmik wrote: > Move pxamci to mmc slot-gpio API to fix interrupt request. > > It fixes the case where the card detection is on a gpio expander, on I2C > for example on zylonite board. In this case, the card detect netsted > interrupt is called from a threade

[PATCH v2] mmc: pxamci: fix card detect with slot-gpio API

2015-09-16 Thread Robert Jarzmik
Move pxamci to mmc slot-gpio API to fix interrupt request. It fixes the case where the card detection is on a gpio expander, on I2C for example on zylonite board. In this case, the card detect netsted interrupt is called from a threaded interrupt. The request_irq() fails, because a hard irq cannot