Re: [PATCH v2] mm: slowly shrink slabs with a relatively small number of objects

2018-09-06 Thread kbuild test robot
Hi Roman, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.19-rc2 next-20180906] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/

Re: [PATCH v2] mm: slowly shrink slabs with a relatively small number of objects

2018-09-06 Thread Roman Gushchin
On Thu, Sep 06, 2018 at 03:42:07PM +0800, kbuild test robot wrote: > Hi Roman, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v4.19-rc2 next-20180905] > [if your patch is applied to the wrong git tree, please

Re: [PATCH v2] mm: slowly shrink slabs with a relatively small number of objects

2018-09-06 Thread kbuild test robot
Hi Roman, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.19-rc2 next-20180905] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/

Re: [PATCH v2] mm: slowly shrink slabs with a relatively small number of objects

2018-09-05 Thread Roman Gushchin
On Wed, Sep 05, 2018 at 02:35:29PM -0700, Shakeel Butt wrote: > On Wed, Sep 5, 2018 at 2:23 PM Roman Gushchin wrote: > > > > On Wed, Sep 05, 2018 at 01:51:52PM -0700, Andrew Morton wrote: > > > On Tue, 4 Sep 2018 15:47:07 -0700 Roman Gushchin wrote: > > > > > > > Commit 9092c71bb724 ("mm: use sc-

Re: [PATCH v2] mm: slowly shrink slabs with a relatively small number of objects

2018-09-05 Thread Shakeel Butt
On Wed, Sep 5, 2018 at 2:23 PM Roman Gushchin wrote: > > On Wed, Sep 05, 2018 at 01:51:52PM -0700, Andrew Morton wrote: > > On Tue, 4 Sep 2018 15:47:07 -0700 Roman Gushchin wrote: > > > > > Commit 9092c71bb724 ("mm: use sc->priority for slab shrink targets") > > > changed the way how the target s

Re: [PATCH v2] mm: slowly shrink slabs with a relatively small number of objects

2018-09-05 Thread Roman Gushchin
On Wed, Sep 05, 2018 at 01:51:52PM -0700, Andrew Morton wrote: > On Tue, 4 Sep 2018 15:47:07 -0700 Roman Gushchin wrote: > > > Commit 9092c71bb724 ("mm: use sc->priority for slab shrink targets") > > changed the way how the target slab pressure is calculated and > > made it priority-based: > > >

Re: [PATCH v2] mm: slowly shrink slabs with a relatively small number of objects

2018-09-05 Thread Andrew Morton
On Tue, 4 Sep 2018 15:47:07 -0700 Roman Gushchin wrote: > Commit 9092c71bb724 ("mm: use sc->priority for slab shrink targets") > changed the way how the target slab pressure is calculated and > made it priority-based: > > delta = freeable >> priority; > delta *= 4; > do_div(delta, sh

[PATCH v2] mm: slowly shrink slabs with a relatively small number of objects

2018-09-04 Thread Roman Gushchin
Commit 9092c71bb724 ("mm: use sc->priority for slab shrink targets") changed the way how the target slab pressure is calculated and made it priority-based: delta = freeable >> priority; delta *= 4; do_div(delta, shrinker->seeks); The problem is that on a default priority (which is 12)