Re: [PATCH v2] mm: remove MIGRATE_ISOLATE check in hotpath

2013-02-25 Thread Minchan Kim
On Mon, Feb 25, 2013 at 02:50:11PM -0800, Andrew Morton wrote: > On Mon, 25 Feb 2013 11:13:08 +0900 > Minchan Kim wrote: > > > > > > > > > > > > ... > > > > > > > > @@ -683,7 +683,7 @@ static void free_one_page(struct zone *zone, struct > > > > page *page, int order, > > > > zone->pages

Re: [PATCH v2] mm: remove MIGRATE_ISOLATE check in hotpath

2013-02-25 Thread Andrew Morton
On Mon, 25 Feb 2013 11:13:08 +0900 Minchan Kim wrote: > > > > > > > > ... > > > > > > @@ -683,7 +683,7 @@ static void free_one_page(struct zone *zone, struct > > > page *page, int order, > > > zone->pages_scanned = 0; > > > > > > __free_one_page(page, zone, order, migratetype); > > > - if

Re: [PATCH v2] mm: remove MIGRATE_ISOLATE check in hotpath

2013-02-24 Thread Minchan Kim
Hi Andrew, Sorry for late reply and I totally missed it. :( On Tue, Jan 15, 2013 at 03:36:25PM -0800, Andrew Morton wrote: > On Tue, 15 Jan 2013 09:16:46 +0900 > Minchan Kim wrote: > > > Now mm several functions test MIGRATE_ISOLATE and some of those > > are hotpath but MIGRATE_ISOLATE is used

Re: [PATCH v2] mm: remove MIGRATE_ISOLATE check in hotpath

2013-01-15 Thread Andrew Morton
On Tue, 15 Jan 2013 09:16:46 +0900 Minchan Kim wrote: > Now mm several functions test MIGRATE_ISOLATE and some of those > are hotpath but MIGRATE_ISOLATE is used only if we enable > CONFIG_MEMORY_ISOLATION(ie, CMA, memory-hotplug and memory-failure) > which are not common config option. So let's

Re: [PATCH v2] mm: remove MIGRATE_ISOLATE check in hotpath

2013-01-15 Thread Michal Nazarewicz
On Tue, Jan 15 2013, Minchan Kim wrote: > Now mm several functions test MIGRATE_ISOLATE and some of those > are hotpath but MIGRATE_ISOLATE is used only if we enable > CONFIG_MEMORY_ISOLATION(ie, CMA, memory-hotplug and memory-failure) > which are not common config option. So let's not add unnecess

[PATCH v2] mm: remove MIGRATE_ISOLATE check in hotpath

2013-01-14 Thread Minchan Kim
Now mm several functions test MIGRATE_ISOLATE and some of those are hotpath but MIGRATE_ISOLATE is used only if we enable CONFIG_MEMORY_ISOLATION(ie, CMA, memory-hotplug and memory-failure) which are not common config option. So let's not add unnecessary overhead and code when we don't enable CONFI