Re: [PATCH v2] mm: memcontrol: replace the loop with a list_for_each_entry()

2021-02-05 Thread Shakeel Butt
On Thu, Feb 4, 2021 at 8:39 AM Muchun Song wrote: > > The rule of list walk has gone since: > > commit a9d5adeeb4b2 ("mm/memcontrol: allow to uncharge page without using > page->lru field") > > So remove the strange comment and replace the loop with a > list_for_each_entry(). > > There is only o

Re: [PATCH v2] mm: memcontrol: replace the loop with a list_for_each_entry()

2021-02-05 Thread Michal Hocko
On Fri 05-02-21 00:30:55, Muchun Song wrote: > The rule of list walk has gone since: > > commit a9d5adeeb4b2 ("mm/memcontrol: allow to uncharge page without using > page->lru field") > > So remove the strange comment and replace the loop with a > list_for_each_entry(). > > There is only one ca

Re: [PATCH v2] mm: memcontrol: replace the loop with a list_for_each_entry()

2021-02-04 Thread Miaohe Lin
Hi: On 2021/2/5 0:30, Muchun Song wrote: > The rule of list walk has gone since: > > commit a9d5adeeb4b2 ("mm/memcontrol: allow to uncharge page without using > page->lru field") > > So remove the strange comment and replace the loop with a > list_for_each_entry(). > > There is only one caller

Re: [PATCH v2] mm: memcontrol: replace the loop with a list_for_each_entry()

2021-02-04 Thread Roman Gushchin
On Fri, Feb 05, 2021 at 12:30:55AM +0800, Muchun Song wrote: > The rule of list walk has gone since: > > commit a9d5adeeb4b2 ("mm/memcontrol: allow to uncharge page without using > page->lru field") > > So remove the strange comment and replace the loop with a > list_for_each_entry(). > > Ther

Re: [PATCH v2] mm: memcontrol: replace the loop with a list_for_each_entry()

2021-02-04 Thread Johannes Weiner
On Fri, Feb 05, 2021 at 12:30:55AM +0800, Muchun Song wrote: > The rule of list walk has gone since: > > commit a9d5adeeb4b2 ("mm/memcontrol: allow to uncharge page without using > page->lru field") > > So remove the strange comment and replace the loop with a > list_for_each_entry(). > > Ther

[PATCH v2] mm: memcontrol: replace the loop with a list_for_each_entry()

2021-02-04 Thread Muchun Song
The rule of list walk has gone since: commit a9d5adeeb4b2 ("mm/memcontrol: allow to uncharge page without using page->lru field") So remove the strange comment and replace the loop with a list_for_each_entry(). There is only one caller of the uncharge_list(). So just fold it into mem_cgroup_un