Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-23 Thread Pavel Machek
Hi! > The __apply_to_page_range() function is also used to change and/or > allocate page-table pages in the vmalloc area of the address space. > Make sure these changes get synchronized to other page-tables in the > system by calling arch_sync_kernel_mappings() when necessary. > > Tested-by: Chri

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-22 Thread Pavel Machek
Hi! > > > The __apply_to_page_range() function is also used to change and/or > > > allocate page-table pages in the vmalloc area of the address space. > > > Make sure these changes get synchronized to other page-tables in the > > > system by calling arch_sync_kernel_mappings() when necessary. > >

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-22 Thread Joerg Roedel
On Sat, Aug 22, 2020 at 12:31:55PM +0100, Chris Wilson wrote: > The active ingredient was > > 7f0a002b5a21 ("x86/mm: remove vmalloc faulting") Right, that is what bisection will point to. Thanks for collecting all the info and updating the commit message! Regards, Joerg

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-22 Thread Joerg Roedel
On Fri, Aug 21, 2020 at 12:18:41PM -0700, Linus Torvalds wrote: > It also strikes me that I think the only architecture that uses the > whole arch_sync_kernel_mappings() thing is now just x86-32. > > [ Well, x86-64 still has it, but that's because we undid the 64-bit > removal, but it's on the ver

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-22 Thread Chris Wilson
Quoting Chris Wilson (2020-08-22 00:39:09) > Quoting Andrew Morton (2020-08-21 23:34:12) > > On Fri, 21 Aug 2020 14:37:46 +0200 Joerg Roedel wrote: > > > > > The __apply_to_page_range() function is also used to change and/or > > > allocate page-table pages in the vmalloc area of the address space

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-21 Thread Chris Wilson
Quoting Andrew Morton (2020-08-21 23:34:12) > On Fri, 21 Aug 2020 14:37:46 +0200 Joerg Roedel wrote: > > > The __apply_to_page_range() function is also used to change and/or > > allocate page-table pages in the vmalloc area of the address space. > > Make sure these changes get synchronized to oth

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-21 Thread Andrew Morton
On Fri, 21 Aug 2020 14:37:46 +0200 Joerg Roedel wrote: > The __apply_to_page_range() function is also used to change and/or > allocate page-table pages in the vmalloc area of the address space. > Make sure these changes get synchronized to other page-tables in the > system by calling arch_sync_ke

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-21 Thread Pavel Machek
Hi! > > > The __apply_to_page_range() function is also used to change and/or > > > allocate page-table pages in the vmalloc area of the address space. > > > Make sure these changes get synchronized to other page-tables in the > > > system by calling arch_sync_kernel_mappings() when necessary. > >

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-21 Thread Chris Wilson
Quoting Andrew Morton (2020-08-21 21:35:48) > On Fri, 21 Aug 2020 14:37:46 +0200 Joerg Roedel wrote: > > > The __apply_to_page_range() function is also used to change and/or > > allocate page-table pages in the vmalloc area of the address space. > > Make sure these changes get synchronized to oth

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-21 Thread Andrew Morton
On Fri, 21 Aug 2020 14:37:46 +0200 Joerg Roedel wrote: > The __apply_to_page_range() function is also used to change and/or > allocate page-table pages in the vmalloc area of the address space. > Make sure these changes get synchronized to other page-tables in the > system by calling arch_sync_ke

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-21 Thread Linus Torvalds
On Fri, Aug 21, 2020 at 5:38 AM Joerg Roedel wrote: > > From: Joerg Roedel > > The __apply_to_page_range() function is also used to change and/or > allocate page-table pages in the vmalloc area of the address space. > Make sure these changes get synchronized to other page-tables in the > system b

Re: [PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-21 Thread Chris Wilson
Quoting Joerg Roedel (2020-08-21 13:37:46) > From: Joerg Roedel > > The __apply_to_page_range() function is also used to change and/or > allocate page-table pages in the vmalloc area of the address space. > Make sure these changes get synchronized to other page-tables in the > system by calling a

[PATCH v2] mm: Track page table modifications in __apply_to_page_range()

2020-08-21 Thread Joerg Roedel
From: Joerg Roedel The __apply_to_page_range() function is also used to change and/or allocate page-table pages in the vmalloc area of the address space. Make sure these changes get synchronized to other page-tables in the system by calling arch_sync_kernel_mappings() when necessary. Tested-by: