Re: [PATCH v2] mm/zsmalloc: add statistics support

2015-01-12 Thread Seth Jennings
On Tue, Dec 23, 2014 at 11:40:45AM +0900, Minchan Kim wrote: > Hi Ganesh, > > On Tue, Dec 23, 2014 at 10:26:12AM +0800, Ganesh Mahendran wrote: > > Hello Minchan > > > > 2014-12-20 10:25 GMT+08:00 Minchan Kim : > > > Hey Ganesh, > > > > > > On Sat, Dec 20, 2014 at 09:43:34AM +0800, Ganesh Mahendr

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-22 Thread Minchan Kim
Hi Ganesh, On Tue, Dec 23, 2014 at 10:26:12AM +0800, Ganesh Mahendran wrote: > Hello Minchan > > 2014-12-20 10:25 GMT+08:00 Minchan Kim : > > Hey Ganesh, > > > > On Sat, Dec 20, 2014 at 09:43:34AM +0800, Ganesh Mahendran wrote: > >> 2014-12-20 8:23 GMT+08:00 Minchan Kim : > >> > On Fri, Dec 19, 2

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-22 Thread Ganesh Mahendran
Hello Minchan 2014-12-20 10:25 GMT+08:00 Minchan Kim : > Hey Ganesh, > > On Sat, Dec 20, 2014 at 09:43:34AM +0800, Ganesh Mahendran wrote: >> 2014-12-20 8:23 GMT+08:00 Minchan Kim : >> > On Fri, Dec 19, 2014 at 04:17:56PM -0800, Andrew Morton wrote: >> >> On Sat, 20 Dec 2014 09:10:43 +0900 Minchan

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Minchan Kim
Hey Ganesh, On Sat, Dec 20, 2014 at 09:43:34AM +0800, Ganesh Mahendran wrote: > 2014-12-20 8:23 GMT+08:00 Minchan Kim : > > On Fri, Dec 19, 2014 at 04:17:56PM -0800, Andrew Morton wrote: > >> On Sat, 20 Dec 2014 09:10:43 +0900 Minchan Kim wrote: > >> > >> > > It involves rehashing a lengthy argum

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Ganesh Mahendran
2014-12-20 8:23 GMT+08:00 Minchan Kim : > On Fri, Dec 19, 2014 at 04:17:56PM -0800, Andrew Morton wrote: >> On Sat, 20 Dec 2014 09:10:43 +0900 Minchan Kim wrote: >> >> > > It involves rehashing a lengthy argument with Greg. >> > >> > Okay. Then, Ganesh, >> > please add warn message about duplicaed

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Ganesh Mahendran
Hello Andrew, Thanks for your review. 2014-12-20 6:32 GMT+08:00 Andrew Morton : > On Fri, 19 Dec 2014 20:55:19 +0800 Ganesh Mahendran > wrote: > >> Keeping fragmentation of zsmalloc in a low level is our target. But now >> we still need to add the debug code in zsmalloc to get the quantitative

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Minchan Kim
On Sat, Dec 20, 2014 at 09:23:03AM +0900, Minchan Kim wrote: > On Fri, Dec 19, 2014 at 04:17:56PM -0800, Andrew Morton wrote: > > On Sat, 20 Dec 2014 09:10:43 +0900 Minchan Kim wrote: > > > > > > It involves rehashing a lengthy argument with Greg. > > > > > > Okay. Then, Ganesh, > > > please add

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Minchan Kim
On Fri, Dec 19, 2014 at 04:17:56PM -0800, Andrew Morton wrote: > On Sat, 20 Dec 2014 09:10:43 +0900 Minchan Kim wrote: > > > > It involves rehashing a lengthy argument with Greg. > > > > Okay. Then, Ganesh, > > please add warn message about duplicaed name possibility althoug > > it's unlikely as

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Andrew Morton
On Sat, 20 Dec 2014 09:10:43 +0900 Minchan Kim wrote: > > It involves rehashing a lengthy argument with Greg. > > Okay. Then, Ganesh, > please add warn message about duplicaed name possibility althoug > it's unlikely as it is. Oh, getting EEXIST is easy with this patch. Just create and destroy

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Minchan Kim
On Fri, Dec 19, 2014 at 04:06:48PM -0800, Andrew Morton wrote: > On Sat, 20 Dec 2014 08:58:52 +0900 Minchan Kim wrote: > > > On Fri, Dec 19, 2014 at 03:45:48PM -0800, Andrew Morton wrote: > > > On Sat, 20 Dec 2014 08:39:37 +0900 Minchan Kim wrote: > > > > > > > Then, we should fix debugfs_creat

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Andrew Morton
On Sat, 20 Dec 2014 08:58:52 +0900 Minchan Kim wrote: > On Fri, Dec 19, 2014 at 03:45:48PM -0800, Andrew Morton wrote: > > On Sat, 20 Dec 2014 08:39:37 +0900 Minchan Kim wrote: > > > > > Then, we should fix debugfs_create_dir can return errno to propagate the > > > error > > > to end user who

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Minchan Kim
On Fri, Dec 19, 2014 at 03:45:48PM -0800, Andrew Morton wrote: > On Sat, 20 Dec 2014 08:39:37 +0900 Minchan Kim wrote: > > > Then, we should fix debugfs_create_dir can return errno to propagate the > > error > > to end user who can know it was failed ENOMEM or EEXIST. > > Impractical. Every ca

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Andrew Morton
On Sat, 20 Dec 2014 08:39:37 +0900 Minchan Kim wrote: > Then, we should fix debugfs_create_dir can return errno to propagate the error > to end user who can know it was failed ENOMEM or EEXIST. Impractical. Every caller of every debugfs interface will need to be changed! It's really irritating

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Minchan Kim
On Fri, Dec 19, 2014 at 02:32:44PM -0800, Andrew Morton wrote: > On Fri, 19 Dec 2014 20:55:19 +0800 Ganesh Mahendran > wrote: > > > Keeping fragmentation of zsmalloc in a low level is our target. But now > > we still need to add the debug code in zsmalloc to get the quantitative > > data. > >

Re: [PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Andrew Morton
On Fri, 19 Dec 2014 20:55:19 +0800 Ganesh Mahendran wrote: > Keeping fragmentation of zsmalloc in a low level is our target. But now > we still need to add the debug code in zsmalloc to get the quantitative data. > > This patch adds a new configuration CONFIG_ZSMALLOC_STAT to enable the > stati

[PATCH v2] mm/zsmalloc: add statistics support

2014-12-19 Thread Ganesh Mahendran
Keeping fragmentation of zsmalloc in a low level is our target. But now we still need to add the debug code in zsmalloc to get the quantitative data. This patch adds a new configuration CONFIG_ZSMALLOC_STAT to enable the statistics collection for developers. Currently only the objects statatitics