Re: [PATCH v2] mfd:rtsx: do retry when dma transfer error

2017-01-05 Thread 冯伟linux
> So this is function is SD card specific? > > In which case, why isn't it in the SD card driver? Dma tans error really because of the wrong byte sequence rather than the invalid argument, so we use EILSEQ instead of EINVAL. SD and memstick driver are all use this to transmit data, so it was put i

Re: [PATCH v2] mfd:rtsx: do retry when dma transfer error

2017-01-05 Thread Lee Jones
On Thu, 05 Jan 2017, 冯伟linux wrote: > > + err = -EILSEQ; > > Why are you using this error code? > > > > when kernel receive the error number is EILSEQ, the SD card requeset > will be retried for some times, instead of dropping it directly. > so we use EILSEQ and frequency reduction to e

Re: [PATCH v2] mfd:rtsx: do retry when dma transfer error

2017-01-05 Thread 冯伟linux
> + err = -EILSEQ; > Why are you using this error code? > when kernel receive the error number is EILSEQ, the SD card requeset will be retried for some times, instead of dropping it directly. so we use EILSEQ and frequency reduction to ensure data can be transmitted correctly as much

Re: [PATCH v2] mfd:rtsx: do retry when dma transfer error

2017-01-04 Thread Lee Jones
On Wed, 04 Jan 2017, steven_f...@realsil.com.cn wrote: > From: steven_feng > > the request should be reissued when dma transfer error. > for rts5227, the clock freq need to step reduce when error occurred. > > Signed-off-by: steven_feng > --- > drivers/mfd/rtsx_pcr.c | 16 ++

[PATCH v2] mfd:rtsx: do retry when dma transfer error

2017-01-04 Thread steven_feng
From: steven_feng the request should be reissued when dma transfer error. for rts5227, the clock freq need to step reduce when error occurred. Signed-off-by: steven_feng --- drivers/mfd/rtsx_pcr.c | 16 ++-- include/linux/mfd/rtsx_pci.h | 4 2 files changed, 18 insertio