Re: [PATCH v2] kunit: fix checkpatch warning

2021-03-10 Thread Shuah Khan
On 3/4/21 4:12 PM, Shuah Khan wrote: On 3/3/21 9:35 PM, Lucas Stankus wrote: On Wed, Mar 03, 2021 at 12:56:05PM -0800, Brendan Higgins wrote: Did you change anything other than fixing the Signed-off-by that Shuah requested? No, I only fixed the Signed-off-by warning. Generally when you make

Re: [PATCH v2] kunit: fix checkpatch warning

2021-03-04 Thread Shuah Khan
On 3/3/21 9:35 PM, Lucas Stankus wrote: On Wed, Mar 03, 2021 at 12:56:05PM -0800, Brendan Higgins wrote: Did you change anything other than fixing the Signed-off-by that Shuah requested? No, I only fixed the Signed-off-by warning. Generally when you make a small change after receiving a Revi

Re: [PATCH v2] kunit: fix checkpatch warning

2021-03-03 Thread Lucas Stankus
On Wed, Mar 03, 2021 at 12:56:05PM -0800, Brendan Higgins wrote: > Did you change anything other than fixing the Signed-off-by that Shuah > requested? No, I only fixed the Signed-off-by warning. > Generally when you make a small change after receiving a Reviewed-by > (especially one so small as h

Re: [PATCH v2] kunit: fix checkpatch warning

2021-03-03 Thread Brendan Higgins
On Tue, Mar 2, 2021 at 6:03 PM Lucas Stankus wrote: > > Tidy up code by fixing the following checkpatch warnings: > CHECK: Alignment should match open parenthesis > CHECK: Lines should not end with a '(' > > Signed-off-by: Lucas Stankus Did you change anything other than fixing the Signed-off-by

[PATCH v2] kunit: fix checkpatch warning

2021-03-03 Thread Lucas Stankus
Tidy up code by fixing the following checkpatch warnings: CHECK: Alignment should match open parenthesis CHECK: Lines should not end with a '(' Signed-off-by: Lucas Stankus --- Change log v1 -> v2 fixed signed-off-by tag lib/kunit/assert.c | 31 --- 1 file changed, 20