Re: [PATCH v2] kprobes/x86: Use 5-byte NOP when the code might be modified by ftrace

2015-02-20 Thread Petr Mladek
On Wed 2015-02-18 22:22:05, Ingo Molnar wrote: > > * Petr Mladek wrote: > > > On Tue 2015-02-03 16:41:39, Masami Hiramatsu wrote: > > > (2015/02/03 2:48), Petr Mladek wrote: > > > > can_probe() checks if the given address points to the beginning of > > > > an instruction. It analyzes all the ins

Re: [PATCH v2] kprobes/x86: Use 5-byte NOP when the code might be modified by ftrace

2015-02-18 Thread Ingo Molnar
* Petr Mladek wrote: > On Tue 2015-02-03 16:41:39, Masami Hiramatsu wrote: > > (2015/02/03 2:48), Petr Mladek wrote: > > > can_probe() checks if the given address points to the beginning of > > > an instruction. It analyzes all the instructions from the beginning > > > of the function until the

Re: [PATCH v2] kprobes/x86: Use 5-byte NOP when the code might be modified by ftrace

2015-02-03 Thread Petr Mladek
On Tue 2015-02-03 12:38:28, Petr Mladek wrote: > On Tue 2015-02-03 16:41:39, Masami Hiramatsu wrote: > > (2015/02/03 2:48), Petr Mladek wrote: > > > can_probe() checks if the given address points to the beginning of > > > an instruction. It analyzes all the instructions from the beginning > > > of

Re: Re: [PATCH v2] kprobes/x86: Use 5-byte NOP when the code might be modified by ftrace

2015-02-03 Thread Masami Hiramatsu
(2015/02/03 20:38), Petr Mladek wrote: > On Tue 2015-02-03 16:41:39, Masami Hiramatsu wrote: >> (2015/02/03 2:48), Petr Mladek wrote: >>> can_probe() checks if the given address points to the beginning of >>> an instruction. It analyzes all the instructions from the beginning >>> of the function un

Re: [PATCH v2] kprobes/x86: Use 5-byte NOP when the code might be modified by ftrace

2015-02-03 Thread Petr Mladek
On Tue 2015-02-03 16:41:39, Masami Hiramatsu wrote: > (2015/02/03 2:48), Petr Mladek wrote: > > can_probe() checks if the given address points to the beginning of > > an instruction. It analyzes all the instructions from the beginning > > of the function until the given address. The code might be m

Re: [PATCH v2] kprobes/x86: Use 5-byte NOP when the code might be modified by ftrace

2015-02-02 Thread Masami Hiramatsu
(2015/02/03 2:48), Petr Mladek wrote: > can_probe() checks if the given address points to the beginning of > an instruction. It analyzes all the instructions from the beginning > of the function until the given address. The code might be modified > by another Kprobe. In this case, the current code

[PATCH v2] kprobes/x86: Use 5-byte NOP when the code might be modified by ftrace

2015-02-02 Thread Petr Mladek
can_probe() checks if the given address points to the beginning of an instruction. It analyzes all the instructions from the beginning of the function until the given address. The code might be modified by another Kprobe. In this case, the current code is read into a buffer, int3 breakpoint is repl