Re: [PATCH v2] kdb: Refactor env variables get/set code

2021-02-08 Thread Sumit Garg
Hi Daniel, On Fri, 5 Feb 2021 at 23:06, Daniel Thompson wrote: > > On Thu, Feb 04, 2021 at 03:44:20PM +0530, Sumit Garg wrote: > > @@ -318,6 +318,65 @@ int kdbgetintenv(const char *match, int *value) > > } > > > > /* > > + * kdb_setenv() - Alter an existing environment variable or create a new

Re: [PATCH v2] kdb: Refactor env variables get/set code

2021-02-05 Thread Daniel Thompson
On Thu, Feb 04, 2021 at 03:44:20PM +0530, Sumit Garg wrote: > @@ -318,6 +318,65 @@ int kdbgetintenv(const char *match, int *value) > } > > /* > + * kdb_setenv() - Alter an existing environment variable or create a new one. > + * @var: Name of the variable > + * @val: Value of the variable > + *

Re: [PATCH v2] kdb: Refactor env variables get/set code

2021-02-04 Thread Doug Anderson
Hi, On Thu, Feb 4, 2021 at 2:14 AM Sumit Garg wrote: > > Add two new kdb environment access methods as kdb_setenv() and > kdb_printenv() in order to abstract out environment access code > from kdb command functions. > > Also, replace (char *)0 with NULL as an initializer for environment > variabl

[PATCH v2] kdb: Refactor env variables get/set code

2021-02-04 Thread Sumit Garg
Add two new kdb environment access methods as kdb_setenv() and kdb_printenv() in order to abstract out environment access code from kdb command functions. Also, replace (char *)0 with NULL as an initializer for environment variables array. Signed-off-by: Sumit Garg --- Changes in v2: - Get rid