Re: [PATCH v2] jbd2: fix potential double free

2019-05-11 Thread Theodore Ts'o
On Fri, May 10, 2019 at 06:36:48PM +0800, Chengguang Xu wrote: > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index 37e16d969925..0f1ac43d0560 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -2299,7 +2299,7 @@ static void jbd2_journal_destroy_slabs(void) > } > } > >

Re: [PATCH v2] jbd2: fix potential double free

2019-05-11 Thread Theodore Ts'o
On Fri, May 10, 2019 at 06:36:48PM +0800, Chengguang Xu wrote: > When fail from creating cache jbd2_inode_cache, we will > destroy previously created cache jbd2_handle_cache twice. > This patch fixes it by sperating each cache > initialization/destruction to individual function. > > Signed-off-by:

[PATCH v2] jbd2: fix potential double free

2019-05-10 Thread Chengguang Xu
When fail from creating cache jbd2_inode_cache, we will destroy previously created cache jbd2_handle_cache twice. This patch fixes it by sperating each cache initialization/destruction to individual function. Signed-off-by: Chengguang Xu --- v2: - Seperate cache initialization/destruction to indi