Re: [PATCH v2] include: Remove pagemap.h from blkdev.h

2021-03-10 Thread William Kucharski
Nice cleanup, IMHO. Reviewed-by: William Kucharski > On Mar 9, 2021, at 12:57 PM, Matthew Wilcox (Oracle) > wrote: > > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h i

Re: [PATCH v2] include: Remove pagemap.h from blkdev.h

2021-03-10 Thread Martin K. Petersen
Matthew, > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h is probably included too widely, > but untangling that dependency is harder and this solves my problem. > x86 al

Re: [PATCH v2] include: Remove pagemap.h from blkdev.h

2021-03-10 Thread Coly Li
On 3/10/21 3:57 AM, Matthew Wilcox (Oracle) wrote: > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h is probably included too widely, > but untangling that dependency is hard

Re: [PATCH v2] include: Remove pagemap.h from blkdev.h

2021-03-10 Thread Christoph Hellwig
On Tue, Mar 09, 2021 at 07:57:47PM +, Matthew Wilcox (Oracle) wrote: > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h is probably included too widely, > but untangling t

Re: [PATCH v2] include: Remove pagemap.h from blkdev.h

2021-03-09 Thread Jens Axboe
On 3/9/21 12:57 PM, Matthew Wilcox (Oracle) wrote: > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h is probably included too widely, > but untangling that dependency is hard

Re: [PATCH v2] include: Remove pagemap.h from blkdev.h

2021-03-09 Thread Dan Williams
On Tue, Mar 9, 2021 at 11:59 AM Matthew Wilcox (Oracle) wrote: > > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h is probably included too widely, > but untangling that dep

[PATCH v2] include: Remove pagemap.h from blkdev.h

2021-03-09 Thread Matthew Wilcox (Oracle)
My UEK-derived config has 1030 files depending on pagemap.h before this change. Afterwards, just 326 files need to be rebuilt when I touch pagemap.h. I think blkdev.h is probably included too widely, but untangling that dependency is harder and this solves my problem. x86 allmodconfig builds, but