Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec

2014-12-05 Thread Doug Anderson
Hi, On Thu, Dec 4, 2014 at 11:03 AM, Wolfram Sang wrote: > >> > New binding should have the "-ns" suffix, right? So, I'd vote to add the >> > suffix to the new bindings and deprecate the ones used in the designware >> > driver: "i2c-scl-rising-time-ns" and "i2c-scl-falling-time-ns" >> > >> > It m

Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec

2014-12-04 Thread Wolfram Sang
> > New binding should have the "-ns" suffix, right? So, I'd vote to add the > > suffix to the new bindings and deprecate the ones used in the designware > > driver: "i2c-scl-rising-time-ns" and "i2c-scl-falling-time-ns" > > > > It might be a little more work now, but it will help us in the future

Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec

2014-12-04 Thread Doug Anderson
Wolfram, On Thu, Dec 4, 2014 at 10:40 AM, Wolfram Sang wrote: > >> If you don't read all the below, my belief is that we should simply >> rename the strings in Addy's patch. We should change "rise-ns" to >> "i2c-scl-rising-time" and "fall-ns" to "i2c-scl-falling-time". >> Wolfram: can you confir

Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec

2014-12-04 Thread Wolfram Sang
> If you don't read all the below, my belief is that we should simply > rename the strings in Addy's patch. We should change "rise-ns" to > "i2c-scl-rising-time" and "fall-ns" to "i2c-scl-falling-time". > Wolfram: can you confirm this is OK? I'm voting to leave the "-ns" > off the end of both to

Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec

2014-12-03 Thread Doug Anderson
Wolfram, On Wed, Dec 3, 2014 at 3:15 AM, Wolfram Sang wrote: > >> + - rise-ns : Number of nanoseconds the signal takes to rise (t(r) in i2c >> spec). >> + If not specified this is assumed to be the max the spec allows >> + (1000 ns for standard mode, 300 ns for fast mode) which

Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec

2014-12-03 Thread Wolfram Sang
> + - rise-ns : Number of nanoseconds the signal takes to rise (t(r) in i2c > spec). > + If not specified this is assumed to be the max the spec allows > + (1000 ns for standard mode, 300 ns for fast mode) which might > + cause slightly slower communication. > + - fall-

Re: [PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec

2014-12-02 Thread Doug Anderson
Addy, On Tue, Dec 2, 2014 at 6:37 PM, Addy Ke wrote: > high_ns calculated from the low division of CLKDIV register is the sum > of actual measured high_ns and rise_ns. The rise time which related to > external pull-up resistor can be up to the maximum rise time in I2C spec. > > In my test, if ext

[PATCH v2] i2c: rk3x: fix bug that cause measured high_ns doesn't meet I2C spec

2014-12-02 Thread Addy Ke
high_ns calculated from the low division of CLKDIV register is the sum of actual measured high_ns and rise_ns. The rise time which related to external pull-up resistor can be up to the maximum rise time in I2C spec. In my test, if external pull-up resistor is 4.7K, rise_ns is about 700ns. So the a