Re: [PATCH v2] i2c: core-smbus: don't trace smbus_reply data on errors

2019-02-11 Thread John Sperbeck
On Mon, Feb 11, 2019 at 6:24 AM Steven Rostedt wrote: > > On Sun, 10 Feb 2019 19:40:21 -0800 > John Sperbeck wrote: > > > If an smbus transfer fails, there's no guarantee that the output > > buffer was written. So, avoid trying to show the output buffer when > > tracing after an error. This was

Re: [PATCH v2] i2c: core-smbus: don't trace smbus_reply data on errors

2019-02-11 Thread Steven Rostedt
On Sun, 10 Feb 2019 19:40:21 -0800 John Sperbeck wrote: > If an smbus transfer fails, there's no guarantee that the output > buffer was written. So, avoid trying to show the output buffer when > tracing after an error. This was 'mostly harmless', but would trip > up kasan checking if left-over

[PATCH v2] i2c: core-smbus: don't trace smbus_reply data on errors

2019-02-10 Thread John Sperbeck
If an smbus transfer fails, there's no guarantee that the output buffer was written. So, avoid trying to show the output buffer when tracing after an error. This was 'mostly harmless', but would trip up kasan checking if left-over cruft in byte 0 is a large length, causing us to read from unwritt