Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-06-04 Thread Wolfram Sang
On Sun, Jan 31, 2016 at 04:33:00PM +0100, Jean-Michel Hautbois wrote: > Some I2C devices have multiple addresses assigned, for example each address > corresponding to a different internal register map page of the device. > So far drivers which need support for this have handled this with a driver >

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-06-03 Thread Lars-Peter Clausen
On 04/25/2016 09:41 AM, Mika Westerberg wrote: > On Mon, Apr 25, 2016 at 09:39:41AM +0200, Wolfram Sang wrote: >> On Mon, Apr 25, 2016 at 10:25:53AM +0300, Mika Westerberg wrote: >>> On Sun, Apr 24, 2016 at 10:14:37PM +0200, Wolfram Sang wrote: > The above should work with both DT and ACPI

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-25 Thread Mika Westerberg
On Mon, Apr 25, 2016 at 09:39:41AM +0200, Wolfram Sang wrote: > On Mon, Apr 25, 2016 at 10:25:53AM +0300, Mika Westerberg wrote: > > On Sun, Apr 24, 2016 at 10:14:37PM +0200, Wolfram Sang wrote: > > > > > > > The above should work with both DT and ACPI so I'm OK with the current > > > > patch. We

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-25 Thread Wolfram Sang
On Mon, Apr 25, 2016 at 10:25:53AM +0300, Mika Westerberg wrote: > On Sun, Apr 24, 2016 at 10:14:37PM +0200, Wolfram Sang wrote: > > > > > The above should work with both DT and ACPI so I'm OK with the current > > > patch. We can add ACPI parts later when needed. > > > > Just to make sure, I read

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-25 Thread Mika Westerberg
On Sun, Apr 24, 2016 at 10:14:37PM +0200, Wolfram Sang wrote: > > > The above should work with both DT and ACPI so I'm OK with the current > > patch. We can add ACPI parts later when needed. > > Just to make sure, I read this as an ack for the original patch? Yes :)

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-24 Thread Wolfram Sang
> The above should work with both DT and ACPI so I'm OK with the current > patch. We can add ACPI parts later when needed. Just to make sure, I read this as an ack for the original patch? signature.asc Description: PGP signature

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-19 Thread Srinivas Pandruvada
On Tue, 2016-04-19 at 17:40 +0300, Mika Westerberg wrote: > On Tue, Apr 19, 2016 at 03:31:41PM +0200, Lars-Peter Clausen wrote: > > > > It adds a standard API for dealing with devices that have more than > > one > > address. It uses the normal way of specifying multiple (named) > > address in DT.

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-19 Thread Mika Westerberg
On Tue, Apr 19, 2016 at 03:49:57PM +0200, Wolfram Sang wrote: > > > It is still not clear to me if this supports more than two addresses and > > I stumbled over this as well: "Secondary" doesn't mean "as in second address", > but "as in not primary address". So, more than two are supported. Inde

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-19 Thread Mika Westerberg
On Tue, Apr 19, 2016 at 03:31:41PM +0200, Lars-Peter Clausen wrote: > It adds a standard API for dealing with devices that have more than one > address. It uses the normal way of specifying multiple (named) address in DT. > > reg = <0xa>, <0xb>, <0xc>; > reg-names = "main", "aux1", "aux2"; > > Th

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-19 Thread Wolfram Sang
> It is still not clear to me if this supports more than two addresses and I stumbled over this as well: "Secondary" doesn't mean "as in second address", but "as in not primary address". So, more than two are supported. signature.asc Description: PGP signature

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-19 Thread Lars-Peter Clausen
On 04/19/2016 03:16 PM, Mika Westerberg wrote: > On Tue, Apr 19, 2016 at 03:02:06PM +0200, Lars-Peter Clausen wrote: >> On 04/19/2016 02:40 PM, Mika Westerberg wrote: >>> On Mon, Apr 18, 2016 at 05:26:54PM +0200, Lars-Peter Clausen wrote: A generic API by indexes wont work. The order between D

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-19 Thread Mika Westerberg
On Tue, Apr 19, 2016 at 03:02:06PM +0200, Lars-Peter Clausen wrote: > On 04/19/2016 02:40 PM, Mika Westerberg wrote: > > On Mon, Apr 18, 2016 at 05:26:54PM +0200, Lars-Peter Clausen wrote: > >> A generic API by indexes wont work. The order between DT and ACPI will most > >> likely be different. I'd

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-19 Thread Lars-Peter Clausen
On 04/19/2016 02:40 PM, Mika Westerberg wrote: > On Mon, Apr 18, 2016 at 05:26:54PM +0200, Lars-Peter Clausen wrote: >> A generic API by indexes wont work. The order between DT and ACPI will most >> likely be different. I'd even assume that the order will be different with >> ACPI for the same devi

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-19 Thread Mika Westerberg
On Mon, Apr 18, 2016 at 05:26:54PM +0200, Lars-Peter Clausen wrote: > A generic API by indexes wont work. The order between DT and ACPI will most > likely be different. I'd even assume that the order will be different with > ACPI for the same device on different platforms. Yes, unfortunately that

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-18 Thread Lars-Peter Clausen
On 04/18/2016 05:20 PM, Srinivas Pandruvada wrote: > On Fri, 2016-04-15 at 11:01 +0300, Mika Westerberg wrote: >> +Srinivas >> >> On Sun, Jan 31, 2016 at 04:33:00PM +0100, Jean-Michel Hautbois wrote: >>> >>> Some I2C devices have multiple addresses assigned, for example each >>> address >>> corresp

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-18 Thread Srinivas Pandruvada
On Fri, 2016-04-15 at 11:01 +0300, Mika Westerberg wrote: > +Srinivas > > On Sun, Jan 31, 2016 at 04:33:00PM +0100, Jean-Michel Hautbois wrote: > > > > Some I2C devices have multiple addresses assigned, for example each > > address > > corresponding to a different internal register map page of th

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-15 Thread Mika Westerberg
+Srinivas On Sun, Jan 31, 2016 at 04:33:00PM +0100, Jean-Michel Hautbois wrote: > Some I2C devices have multiple addresses assigned, for example each address > corresponding to a different internal register map page of the device. > So far drivers which need support for this have handled this with

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-04-14 Thread Wolfram Sang
On Sun, Jan 31, 2016 at 04:33:00PM +0100, Jean-Michel Hautbois wrote: > Some I2C devices have multiple addresses assigned, for example each address > corresponding to a different internal register map page of the device. > So far drivers which need support for this have handled this with a driver >

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-03-24 Thread Rob Herring
On Thu, Mar 24, 2016 at 5:11 AM, Jean-Michel Hautbois wrote: > Hi ! > > 2016-02-01 15:46 GMT+01:00 Rob Herring : >> On Sun, Jan 31, 2016 at 04:33:00PM +0100, Jean-Michel Hautbois wrote: >>> Some I2C devices have multiple addresses assigned, for example each address >>> corresponding to a different

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-03-24 Thread Jean-Michel Hautbois
Hi ! 2016-02-01 15:46 GMT+01:00 Rob Herring : > On Sun, Jan 31, 2016 at 04:33:00PM +0100, Jean-Michel Hautbois wrote: >> Some I2C devices have multiple addresses assigned, for example each address >> corresponding to a different internal register map page of the device. >> So far drivers which nee

Re: [PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-02-01 Thread Rob Herring
On Sun, Jan 31, 2016 at 04:33:00PM +0100, Jean-Michel Hautbois wrote: > Some I2C devices have multiple addresses assigned, for example each address > corresponding to a different internal register map page of the device. > So far drivers which need support for this have handled this with a driver >

[PATCH v2] i2c: Add generic support passing secondary devices addresses

2016-01-31 Thread Jean-Michel Hautbois
Some I2C devices have multiple addresses assigned, for example each address corresponding to a different internal register map page of the device. So far drivers which need support for this have handled this with a driver specific and non-generic implementation, e.g. passing the additional address