Re: [PATCH v2] gpiolib: split character device into gpiolib-cdev

2020-06-10 Thread Bartosz Golaszewski
śr., 10 cze 2020 o 11:13 Linus Walleij napisał(a): > > On Tue, Jun 2, 2020 at 4:11 PM Kent Gibson wrote: > > > Split the cdev specific functionality out of gpiolib.c and into > > gpiolib-cdev.c. This improves the readability and maintainability of both > > the cdev and core gpiolib code. > > > >

Re: [PATCH v2] gpiolib: split character device into gpiolib-cdev

2020-06-10 Thread Linus Walleij
On Tue, Jun 2, 2020 at 4:11 PM Kent Gibson wrote: > Split the cdev specific functionality out of gpiolib.c and into > gpiolib-cdev.c. This improves the readability and maintainability of both > the cdev and core gpiolib code. > > Suggested-by: Bartosz Golaszewski > Signed-off-by: Kent Gibson P

Re: [PATCH v2] gpiolib: split character device into gpiolib-cdev

2020-06-05 Thread Bartosz Golaszewski
pt., 5 cze 2020 o 01:30 Kent Gibson napisał(a): > > On Thu, Jun 04, 2020 at 06:22:43PM +0200, Bartosz Golaszewski wrote: > > czw., 4 cze 2020 o 16:18 Kent Gibson napisał(a): > > > > > > > > > > > Is this comment relevant for the character device? > > > > > > > > > > True - that comment should sta

Re: [PATCH v2] gpiolib: split character device into gpiolib-cdev

2020-06-04 Thread Kent Gibson
On Thu, Jun 04, 2020 at 06:22:43PM +0200, Bartosz Golaszewski wrote: > czw., 4 cze 2020 o 16:18 Kent Gibson napisał(a): > > > > > > > > Is this comment relevant for the character device? > > > > > > > True - that comment should stay in gpiolib, and gpiolib-cdev should get > > one of it's own. > >

Re: [PATCH v2] gpiolib: split character device into gpiolib-cdev

2020-06-04 Thread Bartosz Golaszewski
czw., 4 cze 2020 o 16:18 Kent Gibson napisał(a): > > > > > Is this comment relevant for the character device? > > > > True - that comment should stay in gpiolib, and gpiolib-cdev should get > one of it's own. > > Any suggestions on how to maintain line history? > I know you can trick git by moving

Re: [PATCH v2] gpiolib: split character device into gpiolib-cdev

2020-06-04 Thread Kent Gibson
On Thu, Jun 04, 2020 at 02:04:08PM +0200, Bartosz Golaszewski wrote: > wt., 2 cze 2020 o 16:11 Kent Gibson napisał(a): > > > > Split the cdev specific functionality out of gpiolib.c and into > > gpiolib-cdev.c. This improves the readability and maintainability of both > > the cdev and core gpiolib

Re: [PATCH v2] gpiolib: split character device into gpiolib-cdev

2020-06-04 Thread Bartosz Golaszewski
wt., 2 cze 2020 o 16:11 Kent Gibson napisał(a): > > Split the cdev specific functionality out of gpiolib.c and into > gpiolib-cdev.c. This improves the readability and maintainability of both > the cdev and core gpiolib code. > > Suggested-by: Bartosz Golaszewski > Signed-off-by: Kent Gibson > >

[PATCH v2] gpiolib: split character device into gpiolib-cdev

2020-06-02 Thread Kent Gibson
Split the cdev specific functionality out of gpiolib.c and into gpiolib-cdev.c. This improves the readability and maintainability of both the cdev and core gpiolib code. Suggested-by: Bartosz Golaszewski Signed-off-by: Kent Gibson --- While this patch is complete and ready for review, I don't e