Re: [PATCH v2] gpio: make of_get_named_gpiod_flags() private

2014-05-23 Thread Linus Walleij
On Fri, May 23, 2014 at 5:34 AM, Alexandre Courbot wrote: > Looks like the world did not break this time. However I noticed that > the commit in your tree (and -next) included the changes since v1 in > its log. Is it intended? Yeah I copy that into the changelog sometimes. If I need that info it

Re: [PATCH v2] gpio: make of_get_named_gpiod_flags() private

2014-05-22 Thread Alexandre Courbot
On Wed, May 21, 2014 at 6:16 PM, Linus Walleij wrote: > On Sat, May 17, 2014 at 7:54 AM, Alexandre Courbot > wrote: > >> of_get_named_gpiod_flags() is visible and directly usable by GPIO >> consumers, but it really should not as the gpiod interface relies >> on the simpler gpiod_get() to provide

Re: [PATCH v2] gpio: make of_get_named_gpiod_flags() private

2014-05-21 Thread Linus Walleij
On Sat, May 17, 2014 at 7:54 AM, Alexandre Courbot wrote: > of_get_named_gpiod_flags() is visible and directly usable by GPIO > consumers, but it really should not as the gpiod interface relies > on the simpler gpiod_get() to provide properly-configured GPIOs. > > of_get_named_gpiod_flags() is ju

Re: [PATCH v2] gpio: make of_get_named_gpiod_flags() private

2014-05-19 Thread Thierry Reding
On Tue, May 20, 2014 at 12:07:40AM +0900, Alexandre Courbot wrote: > On Mon, May 19, 2014 at 10:28 PM, Thierry Reding > wrote: > > On Sat, May 17, 2014 at 02:54:50PM +0900, Alexandre Courbot wrote: > >> of_get_named_gpiod_flags() is visible and directly usable by GPIO > >> consumers, but it really

Re: [PATCH v2] gpio: make of_get_named_gpiod_flags() private

2014-05-19 Thread Alexandre Courbot
On Mon, May 19, 2014 at 10:28 PM, Thierry Reding wrote: > On Sat, May 17, 2014 at 02:54:50PM +0900, Alexandre Courbot wrote: >> of_get_named_gpiod_flags() is visible and directly usable by GPIO >> consumers, but it really should not as the gpiod interface relies >> on the simpler gpiod_get() to pr

Re: [PATCH v2] gpio: make of_get_named_gpiod_flags() private

2014-05-19 Thread Thierry Reding
On Sat, May 17, 2014 at 02:54:50PM +0900, Alexandre Courbot wrote: > of_get_named_gpiod_flags() is visible and directly usable by GPIO > consumers, but it really should not as the gpiod interface relies > on the simpler gpiod_get() to provide properly-configured GPIOs. > > of_get_named_gpiod_flags

[PATCH v2] gpio: make of_get_named_gpiod_flags() private

2014-05-16 Thread Alexandre Courbot
of_get_named_gpiod_flags() is visible and directly usable by GPIO consumers, but it really should not as the gpiod interface relies on the simpler gpiod_get() to provide properly-configured GPIOs. of_get_named_gpiod_flags() is just used internally by gpiolib to implement gpiod_get(), and by the ol