Re: [PATCH v2] fusion-mptbase: handle failed allocation for workqueue

2016-02-19 Thread Tomas Henzl
On 18.2.2016 17:55, Ewan Milne wrote: > On Thu, 2016-02-18 at 11:40 -0500, Ewan Milne wrote: >> It also appears to me upon further inspection that the existing code has >> other problems. In particular, once mpt_mapresources() has returned >> with a nonzero error code, it looks like iounmap() shou

Re: [PATCH v2] fusion-mptbase: handle failed allocation for workqueue

2016-02-18 Thread Ewan Milne
On Thu, 2016-02-18 at 11:40 -0500, Ewan Milne wrote: > It also appears to me upon further inspection that the existing code has > other problems. In particular, once mpt_mapresources() has returned > with a nonzero error code, it looks like iounmap() should be called, but > it is not in the case o

Re: [PATCH v2] fusion-mptbase: handle failed allocation for workqueue

2016-02-18 Thread Ewan Milne
On Thu, 2016-02-18 at 10:00 +0100, Johannes Thumshirn wrote: > On Wed, Feb 17, 2016 at 11:40:59PM -0500, Insu Yun wrote: > > the failure of ioc->reset_work_q is checked, > > but not ioc->fw_event_q. > > > > Signed-off-by: Insu Yun > > --- > > drivers/message/fusion/mptbase.c | 44 > > ++

Re: [PATCH v2] fusion-mptbase: handle failed allocation for workqueue

2016-02-18 Thread Johannes Thumshirn
On Wed, Feb 17, 2016 at 11:40:59PM -0500, Insu Yun wrote: > the failure of ioc->reset_work_q is checked, > but not ioc->fw_event_q. > > Signed-off-by: Insu Yun > --- > drivers/message/fusion/mptbase.c | 44 > > 1 file changed, 27 insertions(+), 17 deleti

[PATCH v2] fusion-mptbase: handle failed allocation for workqueue

2016-02-17 Thread Insu Yun
the failure of ioc->reset_work_q is checked, but not ioc->fw_event_q. Signed-off-by: Insu Yun --- drivers/message/fusion/mptbase.c | 44 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fus