Re: [PATCH v2] fujitsu-laptop: Unify max brightness of exported leds

2016-07-03 Thread Jonathan Woithe
On Fri, Jul 01, 2016 at 11:29:14PM +0200, Matej Groma wrote: > On Fri, Jul 01, 2016 at 12:19:27PM -0700, Darren Hart wrote: > > 1) Matej, why do you want to make this change? You mention consistency with > > other LEDs drivers - which ones? Also, why? Is there a tool or something > > that > > expe

Re: [PATCH v2] fujitsu-laptop: Unify max brightness of exported leds

2016-07-01 Thread Matej Groma
On Fri, Jul 01, 2016 at 12:19:27PM -0700, Darren Hart wrote: > On Thu, Jun 30, 2016 at 10:30:57PM +0930, Jonathan Woithe wrote: > > On Wed, Jun 29, 2016 at 09:28:03AM +0200, Matej Groma wrote: > > > Exported leds had maximum brightness previously unset, thus having > > > value 255. Set maximum brig

Re: [PATCH v2] fujitsu-laptop: Unify max brightness of exported leds

2016-07-01 Thread Darren Hart
On Thu, Jun 30, 2016 at 10:30:57PM +0930, Jonathan Woithe wrote: > On Wed, Jun 29, 2016 at 09:28:03AM +0200, Matej Groma wrote: > > Exported leds had maximum brightness previously unset, thus having > > value 255. Set maximum brightness of leds that can only be turned > > off or on to 1, making the

Re: [PATCH v2] fujitsu-laptop: Unify max brightness of exported leds

2016-06-30 Thread Jonathan Woithe
On Wed, Jun 29, 2016 at 09:28:03AM +0200, Matej Groma wrote: > Exported leds had maximum brightness previously unset, thus having > value 255. Set maximum brightness of leds that can only be turned > off or on to 1, making the behavior more consistent with other leds > having binary state. I under

[PATCH v2] fujitsu-laptop: Unify max brightness of exported leds

2016-06-29 Thread Matej Groma
Exported leds had maximum brightness previously unset, thus having value 255. Set maximum brightness of leds that can only be turned off or on to 1, making the behavior more consistent with other leds having binary state. Signed-off-by: Matej Groma --- Changes from v1: made commit message