Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-12-10 Thread Al Viro
On Sun, Dec 10, 2017 at 11:05:15AM +0100, Michal Hocko wrote: > > My unregister_shrinker() fortification patch > > ( > > http://lkml.kernel.org/r/1511523385-6433-1-git-send-email-penguin-ker...@i-love.sakura.ne.jp > > ) > > is not yet in the mmotm tree due to disagreement between Michal and I, b

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-12-10 Thread Michal Hocko
On Sun 10-12-17 11:33:18, Tetsuo Handa wrote: > Al Viro wrote: > > On Sat, Dec 09, 2017 at 08:59:22PM +, Al Viro wrote: > > > On Wed, Nov 29, 2017 at 12:55:15PM +0100, Michal Hocko wrote: > > > > On Thu 23-11-17 14:55:40, Al Viro wrote: > > > > > On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-12-09 Thread Tetsuo Handa
Al Viro wrote: > On Sat, Dec 09, 2017 at 08:59:22PM +, Al Viro wrote: > > On Wed, Nov 29, 2017 at 12:55:15PM +0100, Michal Hocko wrote: > > > On Thu 23-11-17 14:55:40, Al Viro wrote: > > > > On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal Hocko wrote: > > > > > Hopefully less screwed version.

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-12-09 Thread Al Viro
On Sat, Dec 09, 2017 at 08:59:22PM +, Al Viro wrote: > On Wed, Nov 29, 2017 at 12:55:15PM +0100, Michal Hocko wrote: > > On Thu 23-11-17 14:55:40, Al Viro wrote: > > > On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal Hocko wrote: > > > > Hopefully less screwed version. But as I've said I am no

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-12-09 Thread Al Viro
On Wed, Nov 29, 2017 at 12:55:15PM +0100, Michal Hocko wrote: > On Thu 23-11-17 14:55:40, Al Viro wrote: > > On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal Hocko wrote: > > > Hopefully less screwed version. But as I've said I am not really > > > familiar with the code and do not feel competent t

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-11-29 Thread Michal Hocko
On Thu 23-11-17 14:55:40, Al Viro wrote: > On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal Hocko wrote: > > Hopefully less screwed version. But as I've said I am not really > > familiar with the code and do not feel competent to change it so please > > be very careful here. I've moved the shrinke

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-11-23 Thread Michal Hocko
On Fri 24-11-17 06:51:09, Tetsuo Handa wrote: > Al Viro wrote: > > On Fri, Nov 24, 2017 at 12:35:29AM +0900, Tetsuo Handa wrote: > > > Al Viro wrote: > > > > On Fri, Nov 24, 2017 at 12:04:23AM +0900, Tetsuo Handa wrote: > > > > > Al Viro wrote: > > > > > > On Thu, Nov 23, 2017 at 03:35:37PM +0100,

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-11-23 Thread Tetsuo Handa
Al Viro wrote: > On Fri, Nov 24, 2017 at 12:35:29AM +0900, Tetsuo Handa wrote: > > Al Viro wrote: > > > On Fri, Nov 24, 2017 at 12:04:23AM +0900, Tetsuo Handa wrote: > > > > Al Viro wrote: > > > > > On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal Hocko wrote: > > > > > > Hopefully less screwed ver

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-11-23 Thread Al Viro
On Fri, Nov 24, 2017 at 12:35:29AM +0900, Tetsuo Handa wrote: > Al Viro wrote: > > On Fri, Nov 24, 2017 at 12:04:23AM +0900, Tetsuo Handa wrote: > > > Al Viro wrote: > > > > On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal Hocko wrote: > > > > > Hopefully less screwed version. But as I've said I a

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-11-23 Thread Tetsuo Handa
Al Viro wrote: > On Fri, Nov 24, 2017 at 12:04:23AM +0900, Tetsuo Handa wrote: > > Al Viro wrote: > > > On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal Hocko wrote: > > > > Hopefully less screwed version. But as I've said I am not really > > > > familiar with the code and do not feel competent to

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-11-23 Thread Michal Hocko
On Thu 23-11-17 16:02:11, Michal Hocko wrote: > On Thu 23-11-17 14:55:40, Al Viro wrote: > > On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal Hocko wrote: > > > Hopefully less screwed version. But as I've said I am not really > > > familiar with the code and do not feel competent to change it so p

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-11-23 Thread Michal Hocko
On Thu 23-11-17 14:55:40, Al Viro wrote: > On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal Hocko wrote: > > Hopefully less screwed version. But as I've said I am not really > > familiar with the code and do not feel competent to change it so please > > be very careful here. I've moved the shrinke

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-11-23 Thread Al Viro
On Thu, Nov 23, 2017 at 03:35:37PM +0100, Michal Hocko wrote: > Hopefully less screwed version. But as I've said I am not really > familiar with the code and do not feel competent to change it so please > be very careful here. I've moved the shrinker registration to > alloc_super which turned out

Re: [PATCH v2] fs: handle shrinker registration failure in sget_userns

2017-11-23 Thread Michal Hocko
Hopefully less screwed version. But as I've said I am not really familiar with the code and do not feel competent to change it so please be very careful here. I've moved the shrinker registration to alloc_super which turned out to be simpler. --- >From f2a86a9dc45853149d4f29a5ecff77ec4c827b9f Mon