Re: [PATCH v2] fixdep: exit with error code in error branches of do_config_file()

2018-01-09 Thread Masahiro Yamada
2018-01-08 19:17 GMT+09:00 Lukas Bulwahn : > > On Sun, 31 Dec 2017, Masahiro Yamada wrote: > >> 2017-12-22 4:10 GMT+09:00 Lukas Bulwahn : >>> >>> diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c >>> index bbf62cb..4274610 100644 >>> --- a/scripts/basic/fixdep.c >>> +++ b/scripts/basic/f

Re: [PATCH v2] fixdep: exit with error code in error branches of do_config_file()

2018-01-08 Thread Lukas Bulwahn
On Sun, 31 Dec 2017, Masahiro Yamada wrote: 2017-12-22 4:10 GMT+09:00 Lukas Bulwahn : diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c index bbf62cb..4274610 100644 --- a/scripts/basic/fixdep.c +++ b/scripts/basic/fixdep.c @@ -284,19 +284,18 @@ static void do_config_file(const char

Re: [PATCH v2] fixdep: exit with error code in error branches of do_config_file()

2018-01-01 Thread Sam Ravnborg
> > > And would that file be acceptable if it were actually empty There have been cases with empty files in the source tree. And it is not the job of fixdep to do anything special about them. fixdep shall do what it is requested to do, and not more than that. Sam

Re: [PATCH v2] fixdep: exit with error code in error branches of do_config_file()

2018-01-01 Thread Nicholas Mc Guire
On Mon, Jan 01, 2018 at 03:41:10PM +0900, Masahiro Yamada wrote: > 2018-01-01 0:45 GMT+09:00 Nicholas Mc Guire : > > On Sun, Dec 31, 2017 at 01:51:33AM +0900, Masahiro Yamada wrote: > >> 2017-12-22 4:10 GMT+09:00 Lukas Bulwahn : > >> > do_config_file() should exit with an error code, and not return

Re: [PATCH v2] fixdep: exit with error code in error branches of do_config_file()

2017-12-31 Thread Masahiro Yamada
2018-01-01 0:45 GMT+09:00 Nicholas Mc Guire : > On Sun, Dec 31, 2017 at 01:51:33AM +0900, Masahiro Yamada wrote: >> 2017-12-22 4:10 GMT+09:00 Lukas Bulwahn : >> > do_config_file() should exit with an error code, and not return if it fails >> > as then the error in do_config_file() would go unnotice

Re: [PATCH v2] fixdep: exit with error code in error branches of do_config_file()

2017-12-31 Thread Nicholas Mc Guire
On Sun, Dec 31, 2017 at 01:51:33AM +0900, Masahiro Yamada wrote: > 2017-12-22 4:10 GMT+09:00 Lukas Bulwahn : > > do_config_file() should exit with an error code, and not return if it fails > > as then the error in do_config_file() would go unnoticed in the current > > code and allow the build to co

Re: [PATCH v2] fixdep: exit with error code in error branches of do_config_file()

2017-12-30 Thread Masahiro Yamada
2017-12-22 4:10 GMT+09:00 Lukas Bulwahn : > do_config_file() should exit with an error code, and not return if it fails > as then the error in do_config_file() would go unnoticed in the current > code and allow the build to continue. The exit with error code will make > the build fail in those very

[PATCH v2] fixdep: exit with error code in error branches of do_config_file()

2017-12-21 Thread Lukas Bulwahn
do_config_file() should exit with an error code, and not return if it fails as then the error in do_config_file() would go unnoticed in the current code and allow the build to continue. The exit with error code will make the build fail in those very exceptional cases. If this occurs, this actually