Re: [PATCH v2] firmware: fix NULL pointer dereference in __fw_load_abort()

2017-01-25 Thread Luis R. Rodriguez
On Wed, Jan 25, 2017 at 04:47:25PM +0100, Greg KH wrote: > On Wed, Jan 25, 2017 at 07:21:18AM -0800, Luis R. Rodriguez wrote: > > Since commit 5d47ec02c37ea632398cb251c884e3a488dff794 > > ("firmware: Correct handling of fw_state_wait() return value") > > fw_load_abort(fw_priv) could be called twice

Re: [PATCH v2] firmware: fix NULL pointer dereference in __fw_load_abort()

2017-01-25 Thread Greg KH
On Wed, Jan 25, 2017 at 07:21:18AM -0800, Luis R. Rodriguez wrote: > Since commit 5d47ec02c37ea632398cb251c884e3a488dff794 > ("firmware: Correct handling of fw_state_wait() return value") > fw_load_abort(fw_priv) could be called twice and lead us to a > kernel crash. This happens only when the firm

[PATCH v2] firmware: fix NULL pointer dereference in __fw_load_abort()

2017-01-25 Thread Luis R. Rodriguez
Since commit 5d47ec02c37ea632398cb251c884e3a488dff794 ("firmware: Correct handling of fw_state_wait() return value") fw_load_abort(fw_priv) could be called twice and lead us to a kernel crash. This happens only when the firmware fallback mechanism (regular or custom) is used. The fallback mechanism

Re: [PATCH v2] firmware: fix NULL pointer dereference in __fw_load_abort()

2017-01-17 Thread Luis R. Rodriguez
On Tue, Jan 17, 2017 at 11:08:46AM +0100, linux-kernel-...@beckhoff.com wrote: > From: Patrick Bruenn > > Since commit 5d47ec02c37ea632398cb251c884e3a488dff794 > ("firmware: Correct handling of fw_state_wait() return value") > fw_load_abort(fw_priv) could be called twice. The first call would > s

[PATCH v2] firmware: fix NULL pointer dereference in __fw_load_abort()

2017-01-17 Thread linux-kernel-dev
From: Patrick Bruenn Since commit 5d47ec02c37ea632398cb251c884e3a488dff794 ("firmware: Correct handling of fw_state_wait() return value") fw_load_abort(fw_priv) could be called twice. The first call would set fw_priv->buf = NULL; and the second call would pass that NULL to __fw_load_abort() which