Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-08-08 Thread Takaya Saeki
Oh yes. That sounds like a good idea. Let me update the patch with it. Thanks, Takaya Saeki

Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-08-07 Thread Steven Rostedt
On Thu, 20 Jun 2024 16:19:03 + Takaya Saeki wrote: > +DECLARE_EVENT_CLASS(mm_filemap_op_page_cache_range, > + > + TP_PROTO( > + struct address_space *mapping, > + pgoff_t index, > + pgoff_t last_index > + ), > + > + TP_ARGS(mapping, index, last_

Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-07-10 Thread Takaya Saeki
Hello Matthew, I'd appreciate it if you could comment on this. Thank you.

Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-07-02 Thread Steven Rostedt
On Tue, 2 Jul 2024 19:27:16 +0900 Takaya Saeki wrote: > Hello all, and thank you so much for the review, Steven and Masami. > > I'm currently considering replacing the `max_ofs` output with > `length`. Please let me know your thoughts. > With the current design, a memory range of an event is an

Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-07-02 Thread Takaya Saeki
Hello all, and thank you so much for the review, Steven and Masami. I'm currently considering replacing the `max_ofs` output with `length`. Please let me know your thoughts. With the current design, a memory range of an event is an inclusive range of [ofs, max_ofs + 4096]. I found the `+4096` part

Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-06-26 Thread Steven Rostedt
On Wed, 26 Jun 2024 21:31:57 +0900 Masami Hiramatsu (Google) wrote: > On Thu, 20 Jun 2024 16:19:03 + > Takaya Saeki wrote: > > > To allow precise tracking of page caches accessed, add new tracepoints > > that trigger when a process actually accesses them. > > > > The ureadahead program use

Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-06-26 Thread Google
On Thu, 20 Jun 2024 16:19:03 + Takaya Saeki wrote: > To allow precise tracking of page caches accessed, add new tracepoints > that trigger when a process actually accesses them. > > The ureadahead program used by ChromeOS traces the disk access of > programs as they start up at boot up. It u

[PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-06-20 Thread Takaya Saeki
To allow precise tracking of page caches accessed, add new tracepoints that trigger when a process actually accesses them. The ureadahead program used by ChromeOS traces the disk access of programs as they start up at boot up. It uses mincore(2) or the 'mm_filemap_add_to_page_cache' trace event to