Re: [PATCH v2] f2fs: replace a build-time warning with runtime WARN_ON

2016-11-02 Thread Arnd Bergmann
On Wednesday 02 November 2016, Chao Yu wrote: > Hi Arnd, Jaegeuk, > > It is trivial, but it's better keep commit *title*, commit log and code > consistent. :) Sorry for my silly mistake, sent it again with a new subject now. Arnd

Re: [PATCH v2] f2fs: replace a build-time warning with runtime WARN_ON

2016-11-02 Thread Chao Yu
Hi Arnd, Jaegeuk, It is trivial, but it's better keep commit *title*, commit log and code consistent. :) Thanks, On 2016/10/27 23:32, Arnd Bergmann wrote: > gcc is unsure about the use of last_ofs_in_node, which might happen > without a prior initialization: > > fs/f2fs//git/arm-soc/fs/f2fs/dat

[PATCH v2] f2fs: replace a build-time warning with runtime WARN_ON

2016-10-27 Thread Arnd Bergmann
gcc is unsure about the use of last_ofs_in_node, which might happen without a prior initialization: fs/f2fs//git/arm-soc/fs/f2fs/data.c: In function ‘f2fs_map_blocks’: fs/f2fs/data.c:799:54: warning: ‘last_ofs_in_node’ may be used uninitialized in this function [-Wmaybe-uninitialized] if (prea